Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for Visual Studio #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MonkeybreadSoftware
Copy link

Added makefile and fixed some compilation errors.

Added makefile and fixed some compilation errors.
@x42
Copy link
Owner

x42 commented Jan 10, 2020

libltc is already known to compile with MSVC (also older compilers).

You also seem to have been using an old version of libltc without git-rebasing your changes.
This pull-request undoes various recent changes to the library and hence cannot be merged as-is.

There are a few nice parts, e.g. some explicit typecasts, but I have zero interest in making this lib strict ANSI-C89 compatible in 2020. I'm sorry.

Also I have no interest in explicit .def and .rc files. I can not maintain them and this information should be automatically generated in the first place.

@x42
Copy link
Owner

x42 commented Jan 10, 2020

I'm curious: which version of MSVC do you use that requires these changes?

@MonkeybreadSoftware
Copy link
Author

I made changes for Visual Studio 2008.
Sorry for picking the wrong version to start.
I appreciate if you include a few of the changes in future versions.

@x42
Copy link
Owner

x42 commented Jan 10, 2020

Odd. The library is known to build with Visual Studio 2005 (version 8) as-is.
Maybe compare to the VC Project used by Ardour: https://github.com/Ardour/ardour/blob/master/libs/libltc/MSVCltc/ltc.vcproj John Emmas succeeded to compile the lib without resorting to adding ANSI-C89 compat.

@MonkeybreadSoftware
Copy link
Author

Oh, I build via command line, so I may have missed a switch for this.

@tp-m
Copy link

tp-m commented May 6, 2023

I can build master successfully with MSVC (vs2019) with my Meson build system port for what it's worth.

(Unit tests fail with MSVC, but that might be a problem with the test code or the wrapper script).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants