-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix config manifest type #973
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hmm, some test types are not compatible with the new Chrome types, with some of the types being stricter. For example, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha interesting that that works but omit doesnt
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
==========================================
- Coverage 82.25% 81.70% -0.55%
==========================================
Files 125 125
Lines 6604 6604
Branches 1104 1098 -6
==========================================
- Hits 5432 5396 -36
- Misses 1158 1194 +36
Partials 14 14 ☔ View full report in Codecov by Sentry. |
fwiw: this is because |
Interesting, thanks for sharing! Learn something new every day lol |
This PR fixes types from #969
Because Chrome's manifest types have an index signature
[key: string]: any
,Omit<chrome.runtime.ManifestV3, ...>
becomesand only the added properties remain in
UserManifest