Refactor Credential Management: Reusable Hook and Code Optimization #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatrakazas
changed the base branch from
feat/protocol-optimization
to
master
gkatrakazas
force-pushed
the
refactor/fetch-data
branch
from
e8e4036 to
6d44a5d
Compare
gkatrakazas
changed the title
gkatrakazas
force-pushed
the
refactor/fetch-data
branch
from
6d44a5d to
b3d3c57
Compare
kkmanos
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors credential management by extracting VC entity fetching logic into a reusable hook, enhancing maintainability and reusability across the app.
It also optimizes credential filtering by grouping instances, adding an 'instance' field, and centralizing credential parsing logic into the CredentialContext.
Additionally, conflicts with the master branch have been resolved, and lint warnings have been addressed.