Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication protocol optimization #492

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

kkmanos
Copy link
Member

@kkmanos kkmanos commented Jan 8, 2025

  • Removed ContainerContext
  • Removed useCheckUrl hook as it had strong dependency with the "App" component and it was increasing the complexity when dealing the popups which were triggered from other components
  • Adopt an architecture that does not use callbacks for keystore changes
  • Remove events that are emitted when the communication protocol is running which were used to trigger the container reloading to keep up to date with the latest keystore instance

This PR introduces the following top-level components that abstract the core functionality of the communication protocol and are dependent on the rest of the react components architecture

UriHandler: A Higher Order Component which is used for handling all the incoming URI requests

OpenID4VPContext: Isolated context to show the credential selection popup. Exports the openID4VP dependency

CredentialParsersContext: Exports credentialParserRegistry dependency which caches all metadata in memory

The following diagram describes the dependency/hierarchy between the different react contexts and Higher Order Components(HOC) in the top level of the React application.

d2(2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant