Unify event architecture between api and keystore #489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #483, the
api
andLocalStorageKeystore
modules now expose two very different ways of attaching event listeners to these services. This PR aims to unify both APIs under a shared architecture based on theEventTarget
type available in the JS engine.As part of that, this also introduces
util.cleanupListeners
to help streamline setting upuseEffect
cleanup handlers to remove stale event listeners. This helper function sets up anAbortController
and provides itssignal
so that event listeners can be automatically removed using thesignal
option ofaddEventListener
.