Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FCM Token Retrieval after Cookie Clearance Issue #191 #196

Merged
merged 16 commits into from
Mar 21, 2024

Conversation

gkatrakazas
Copy link
Member

This PR addresses issue #191 where FCM token retrieval fails with a null value in cases where users have granted notification permissions but later clear their cookies. The proposed changes ensure reliable token fetching in these scenarios.

@gkatrakazas gkatrakazas requested a review from kkmanos March 14, 2024 16:33
@gkatrakazas gkatrakazas linked an issue Mar 14, 2024 that may be closed by this pull request
@gkatrakazas gkatrakazas marked this pull request as draft March 15, 2024 18:40
@gkatrakazas gkatrakazas marked this pull request as ready for review March 19, 2024 11:18
@gkatrakazas gkatrakazas requested a review from emlun March 19, 2024 11:27
src/components/Layout.js Outdated Show resolved Hide resolved
src/components/Layout.js Outdated Show resolved Hide resolved
src/components/PrivateRoute.js Outdated Show resolved Hide resolved
src/components/PrivateRoute.js Outdated Show resolved Hide resolved
src/components/PrivateRoute.js Outdated Show resolved Hide resolved
src/components/Layout.js Outdated Show resolved Hide resolved
src/components/Layout.js Outdated Show resolved Hide resolved
@gkatrakazas gkatrakazas requested a review from emlun March 19, 2024 14:16
Copy link
Member

@emlun emlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@gkatrakazas gkatrakazas merged commit 6abb2c0 into master Mar 21, 2024
2 checks passed
@gkatrakazas gkatrakazas deleted the fix/null-fcmtoken branch April 2, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isolated Issue with FCM Token Retrieval After Cookie Clearance
4 participants