-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FCM Token Retrieval after Cookie Clearance Issue #191 #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatrakazas
force-pushed
the
fix/null-fcmtoken
branch
from
March 14, 2024 16:39
cb79d62
to
232b0f4
Compare
gkatrakazas
force-pushed
the
fix/null-fcmtoken
branch
from
March 19, 2024 07:05
1fbf2a4
to
1df6057
Compare
gkatrakazas
force-pushed
the
fix/null-fcmtoken
branch
from
March 19, 2024 07:23
1df6057
to
4122cdf
Compare
gkatrakazas
force-pushed
the
fix/null-fcmtoken
branch
from
March 19, 2024 11:20
bbbd1f7
to
7f0b20b
Compare
emlun
reviewed
Mar 19, 2024
Co-authored-by: Emil Lundberg <[email protected]>
Co-authored-by: Emil Lundberg <[email protected]>
Co-authored-by: Emil Lundberg <[email protected]>
Co-authored-by: Emil Lundberg <[email protected]>
Co-authored-by: Emil Lundberg <[email protected]>
Add framework for subscribing to events from useApi()
emlun
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
kkmanos
approved these changes
Mar 20, 2024
pstamatop
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #191 where FCM token retrieval fails with a null value in cases where users have granted notification permissions but later clear their cookies. The proposed changes ensure reliable token fetching in these scenarios.