Flip parameter order of generateOpenid4vciProof to match sibling functions #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstamatop
requested review from
kkmanos and
pstamatop
and removed request for
kkmanos
pstamatop
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
createIdTokenandsignJwtPresentationhave the parameter ordernonce, audience, butgenerateOpenid4vciProofhas parameter orderaudience, nonce. Both parameters have the same type, so the type system wouldn't catch a mistake passing arguments in reverse order. This change flips the parameter order to be the same between all three functions, lowering the risk of such a mistake.