Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EditorConfig #184

Merged
merged 8 commits into from
Mar 6, 2024
Merged

Add EditorConfig #184

merged 8 commits into from
Mar 6, 2024

Conversation

emlun
Copy link
Member

@emlun emlun commented Feb 21, 2024

To prevent future issues such as the indentation issues in #183.

@emlun
Copy link
Member Author

emlun commented Feb 21, 2024

Ah, this already conflicts with PR #183 starting in commit 89a3332, so let's merge #183 before this and I'll rebase this to fix the conflicts.

src/assets/images/cred.png Outdated Show resolved Hide resolved
@gkatrakazas
Copy link
Member

Nice, so once we get full ready and merge #183, you can then proceed to close it!

@gkatrakazas
Copy link
Member

gkatrakazas commented Feb 26, 2024

@emlun, the relevant previous PRs have been merged. You have the green light to proceed. When you're ready, ask me for a review just to check before you merge.

Im not sure how easy to fix the conficts which have been after #174 merge

@emlun emlun marked this pull request as ready for review March 6, 2024 15:33
@emlun emlun requested a review from gkatrakazas March 6, 2024 15:35
@emlun emlun merged commit 586f638 into master Mar 6, 2024
2 checks passed
@emlun emlun deleted the editorconfig branch March 6, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants