Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RNExitApp.mm #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update RNExitApp.mm #65

wants to merge 1 commit into from

Conversation

kr-yeon
Copy link

@kr-yeon kr-yeon commented Jun 27, 2023

Apps that look like errors may be rejected by Apple. So I corrected it.

We found that your app includes a UI control for quitting the app. This is not in compliance with the iOS Human Interface Guidelines, as required by the App Store Review Guidelines

Apps that look like errors may be rejected by Apple. So I corrected it.
@wumke
Copy link
Owner

wumke commented Jun 27, 2023

I never created an app with a UI control for quitting the app, only used it to kill the app after a visual warning that rights must be granted for the app to work correctly (which was also mentionned in the app description). If users do not grant the requested rights, my app cannot work. That app never got rejected.

Triggering the suspend does not completely kill the app, if I remember correctly. There has already been a request for 'gracefully close the app', see #62 . This makes sense... but I would like to keep a hard kill as standard in any case, altough an additional method 'suspendApp' would be a nice addition...

I also want to keep functionalty on both platforms as identical as possible, so if you can send a pull request for suspending on both platforms, with an additional method 'suspendApp', I'll merge that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants