added local type #18
Open
added local type #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "aem", | |||
| "version": "0.1.2-alpha.1718453175+e73fab23", | |||
| "version": "0.1.2-alpha.1718453293+5c68305a.dirty", | |||
| @@ -104,7 +111,7 @@ func (ic *InstanceClient) saveProfileScript() error { | |||
| } | |||
|
|
|||
| func (ic *InstanceClient) configureService() error { | |||
| if !ic.data.System.ServiceEnabled || ic.data.Client.Type == "local" { | |||
| if !ic.data.System.ServiceEnabled { | |||
There was a problem hiding this comment.
I don't remeber such bool serviceEnabled in TF provider... why have you introduced it? these providers should not be so different
There was a problem hiding this comment.
system service is must have; we want to maintain only the single and correct way of setting up AEM instances... maintaining variations will increase complexity
There was a problem hiding this comment.
hmm if serviceEnabled = false then runServiceCommand("start") need be replaced by "sh aemw instance launch" command and the similar thing for stopping
There was a problem hiding this comment.
for non-admin usages like on local/dev machine it would be fine
| @@ -102,6 +102,7 @@ type System struct { | |||
| WorkDir string `pulumi:"work_dir,optional"` | |||
| Env map[string]string `pulumi:"env,optional"` | |||
| ServiceEnabled bool `pulumi:"service_enabled,optional"` | |||
| @@ -55,6 +59,8 @@ public sealed class System | |||
|
|
|||
| bool? service_enabled, | |||
krystian-panek-vmltech
requested changes
Jun 17, 2024
| System: compose.SystemArgs{ | ||
| Data_dir: pulumi.String(composeDir), | ||
| Work_dir: pulumi.String(workDir), | ||
| Service_enabled: pulumi.Bool(false), |
There was a problem hiding this comment.
I don't want to have ServiceEnabled here
krystian-panek-vmltech
requested changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.