Moved constat values to constants file

wttech · Jun 28, 2021 · 9873110 · 9873110
1 parent 297f448
commit 9873110
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/cogboard-webapp/src/components/PopoverWithControls.js b/cogboard-webapp/src/components/PopoverWithControls.js
@@ -1,4 +1,8 @@
 import React, { useState } from 'react';
+import {
+  SERVICE_CHECK_RESPONSES,
+  NO_MATCHING_SERVICE_CHECK_RESPONSE
+} from '../constants';
 import copy from 'copy-to-clipboard';
 import {
   CaptionWithPointer,
@@ -8,10 +12,6 @@ import {
 } from './styled';
 import { Button, Popover } from '@material-ui/core';
 
-const NO_MATCHING_RESPONSE = 'NO MATCH';
-const RECEIVED_RESPONSE = 'ACTUAL RESPONSE';
-const EXPECTED_RESPONSE = 'EXPECTED RESPONSE';
-
 export const PopoverWithControls = ({
   title,
   titleHover,
@@ -50,14 +50,18 @@ export const PopoverWithControls = ({
       >
         {withCopy ? <Button onClick={copyBody}>Copy</Button> : null}
         <Button onClick={handlePopoverClose}>Close</Button>
-        {bodyMessage === NO_MATCHING_RESPONSE ? (
+        {bodyMessage === NO_MATCHING_SERVICE_CHECK_RESPONSE ? (
           <StyledPopoverTextWrapper>
             <StyledPopoverText>
-              <StyledPopoverHeader>{EXPECTED_RESPONSE}</StyledPopoverHeader>
+              <StyledPopoverHeader>
+                {SERVICE_CHECK_RESPONSES.expected}
+              </StyledPopoverHeader>
               {expectedResponseBody}
             </StyledPopoverText>
             <StyledPopoverText>
-              <StyledPopoverHeader>{RECEIVED_RESPONSE}</StyledPopoverHeader>
+              <StyledPopoverHeader>
+                {SERVICE_CHECK_RESPONSES.received}
+              </StyledPopoverHeader>
               {body}
             </StyledPopoverText>
           </StyledPopoverTextWrapper>

diff --git a/cogboard-webapp/src/constants/index.js b/cogboard-webapp/src/constants/index.js
@@ -339,3 +339,9 @@ export const NOTIFICATIONS = {
     duration: 3000
   })
 };
+
+export const NO_MATCHING_SERVICE_CHECK_RESPONSE = 'NO MATCH';
+export const SERVICE_CHECK_RESPONSES = {
+  received: 'ACTUAL RESPONSE',
+  expected: 'EXPECTED RESPONSE'
+};