Use custom, lexically ordered, base64 encoding for all paths that will be read by WRStat #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l be read by WRStat.
mjkw31
force-pushed
the
fix/path-encoding
branch
from
72e4ba4 to
2c60c0e
Compare
sb10
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified internal encoding package to use a modified base64 encoding that produces encodings that preserves lexical ordering of paths.
Fixes issue during combine step where the newline and/or tab characters in a path would alter the number of columns in a TSV, which caused an index-out-of-range error as columns numbers didn't match when comparing rows in dgut files.