Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max_mem option to run on low mem machines #51

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Add max_mem option to run on low mem machines #51

merged 4 commits into from
Nov 30, 2023

Conversation

sb10
Copy link
Collaborator

@sb10 sb10 commented Nov 27, 2023

The const memory values are for handling many petabytes of data on high memory machines (and needed because we probably have some kind of memory leak).

For running on less data on small memory machines, we need a max memory option.

@sb10 sb10 marked this pull request as ready for review November 27, 2023 14:50
@sb10 sb10 requested a review from mjkw31 November 27, 2023 14:51
mjkw31
mjkw31 previously approved these changes Nov 27, 2023
Copy link
Collaborator

@mjkw31 mjkw31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mjkw31
Copy link
Collaborator

mjkw31 commented Nov 27, 2023

May need to update the CI config to use the latest Go version.

@sb10 sb10 merged commit ab51e6f into develop Nov 30, 2023
2 checks passed
@sb10 sb10 deleted the maxmem branch November 30, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants