Delint'd.

cmd/decode.go

@@ -38,6 +38,11 @@ import (
 	"github.com/wtsi-ssg/wrstat/v5/internal/encode"
 )
 
+const (
+	statsColumn       = 0
+	byUserGroupColumn = 2
+)
+
 // chtsvCmd represents the chtsv command.
 var decodeCmd = &cobra.Command{
 	Use:   "decode",
@@ -52,7 +57,7 @@ Files with names ending in '.gz' will be decompressed before printing.
 
 Other files are simply copied to stdout.
 `,
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		for _, file := range args {
 			if err := decodeFile(file); err != nil {
 				die("%s", err)
@@ -87,9 +92,11 @@ func decodeFile(file string) error {
 
 	var col int
 
-	if strings.HasSuffix(file, ".byusergroup") {
-		col = 2
-	} else if !strings.HasSuffix(file, ".stats") {
+	if strings.HasSuffix(file, ".byusergroup") { //nolint:gocritic
+		col = byUserGroupColumn
+	} else if strings.HasSuffix(file, ".stats") {
+		col = statsColumn
+	} else {
 		_, err = io.Copy(os.Stdout, r)
 
 		return err
@@ -115,12 +122,14 @@ func decodeColumn(r io.Reader, col int) error {
 		}
 
 		if line == "\n" {
-			w.WriteString(line)
+			if _, err = w.WriteString(line); err != nil {
+				return err
+			}
 
 			continue
 		}
 
-		parts := strings.SplitN(line, "\t", col+2)
+		parts := strings.SplitN(line, "\t", col+2) //nolint:mnd
 
 		parts[col], err = encode.Base64Decode(parts[col])
 		if err != nil {

main_test.go

@@ -773,6 +773,8 @@ func TestWalk(t *testing.T) {
 }
 
 func writeFileStringAndCompress(t *testing.T, path, contents string) {
+	t.Helper()
+
 	writeFileString(t, path, contents)
 
 	f, err := os.Create(path + ".gz")