Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TM-997] Fix: Ensure "record.uuid" is safely accessed in getSiteBbox function #275

Merged
merged 2 commits into from
Jun 24, 2024
Merged

[TM-997] Fix: Ensure "record.uuid" is safely accessed in getSiteBbox function #275

merged 2 commits into from
Jun 24, 2024

Conversation

LimberHope
Copy link
Collaborator

@LimberHope LimberHope commented Jun 24, 2024 •
edited
Loading

Task Link TM-997
Task Link TM-988

@vercel Vercel
Copy link

vercel bot commented Jun 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wri-terramatch-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 7:07pm
wri-terramatch-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 7:07pm

@vercel vercel bot temporarily deployed to Preview – wri-terramatch-storybook June 24, 2024 17:13 Inactive
@LimberHope LimberHope requested a review from roguenet June 24, 2024 18:08
roguenet
roguenet reviewed Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@roguenet roguenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the record doesn't exist, won't this API response not be useful? It seems like this should also have an enabled flag

{
  pathParams: { record?.uuid },
},
{
  enabled: record?.uuid != null
}

@vercel vercel bot temporarily deployed to Preview – wri-terramatch-storybook June 24, 2024 19:04 Inactive
@LimberHope LimberHope merged commit 460e29a into staging Jun 24, 2024
4 checks passed
@LimberHope LimberHope deleted the TM-997-application-error-on-project-stablishment-form branch June 28, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roguenet roguenet roguenet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LimberHope @roguenet