Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TM-850] polygon functionality #248

Merged
merged 26 commits into from
Jun 11, 2024
Merged

[TM-850] polygon functionality #248

merged 26 commits into from
Jun 11, 2024

Conversation

cesarLima1
Copy link
Collaborator

@vercel Vercel
Copy link

vercel bot commented Jun 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wri-terramatch-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 6:49pm
wri-terramatch-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 6:49pm

@vercel vercel bot temporarily deployed to Preview – wri-terramatch-storybook June 7, 2024 21:27 Inactive
@cesarLima1 cesarLima1 changed the title Feat/tm 850 polygon functionality [TM-850] polygon functionality Jun 10, 2024
@vercel vercel bot temporarily deployed to Preview – wri-terramatch-storybook June 10, 2024 13:50 Inactive
@egrojMonroy egrojMonroy force-pushed the feat/TM-850-polygon-functionality branch from 04b42f3 to fb2e118 Compare June 10, 2024 14:17
@vercel vercel bot temporarily deployed to Preview – wri-terramatch-storybook June 10, 2024 14:21 Inactive
@vercel vercel bot temporarily deployed to Preview – wri-terramatch-storybook June 10, 2024 14:40 Inactive
@vercel vercel bot temporarily deployed to Preview – wri-terramatch-storybook June 10, 2024 16:16 Inactive
@roguenet
Copy link
Collaborator

II have a request related to this PR: let's make sure that #244 is merged before this one because this is based on its branch and I'd like to avoid the situation of the 3k lines of diff showing up on the other PR once they're approved. So the process will hopefully be

  • Get the other PR to an approved state and merged in
  • This will then automatically change its base branch to staging (I'm not sure if this happens when the base PR is merged, or if the branch needs to get deleted after merge, but I've seen Github do it recently in my own sequence PRs)
  • Once this one is approved, merge it directly into staging

roguenet
roguenet reviewed Jun 10, 2024
View reviewed changes
.../components/ResourceTabs/PolygonReviewTab/components/CommentarySection/CommentarySection.tsx Outdated Show resolved Hide resolved
src/admin/components/ResourceTabs/PolygonReviewTab/components/PolygonDrawer/PolygonDrawer.tsx Outdated Show resolved Hide resolved
src/admin/components/ResourceTabs/PolygonReviewTab/components/PolygonDrawer/PolygonDrawer.tsx Show resolved Hide resolved
src/admin/components/ResourceTabs/PolygonReviewTab/components/PolygonDrawer/PolygonDrawer.tsx Outdated Show resolved Hide resolved
src/admin/components/ResourceTabs/PolygonReviewTab/components/PolygonDrawer/PolygonDrawer.tsx Outdated Show resolved Hide resolved
src/components/elements/MapPolygonPanel/MapPolygonCheckPanelItem copy.tsx Outdated Show resolved Hide resolved
src/components/elements/MapPolygonPanel/MapPolygonPanelItem.tsx Outdated Show resolved Hide resolved
src/components/elements/MapPolygonPanel/MapPolygonPanelItem.tsx Outdated Show resolved Hide resolved
src/components/extensive/Modal/ModalAdd.tsx Outdated Show resolved Hide resolved
src/pages/site/[uuid]/components/MockecData.ts Outdated Show resolved Hide resolved
Base automatically changed from feat/TM-905-create-map-instance to staging June 10, 2024 19:02
@vercel vercel bot temporarily deployed to Preview – wri-terramatch-storybook June 10, 2024 19:15 Inactive
@vercel vercel bot temporarily deployed to Preview – wri-terramatch-storybook June 10, 2024 19:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wri-terramatch-storybook June 10, 2024 21:08 Inactive
@vercel vercel bot temporarily deployed to Preview – wri-terramatch-storybook June 10, 2024 21:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wri-terramatch-storybook June 10, 2024 21:32 Inactive
@vercel vercel bot temporarily deployed to Preview – wri-terramatch-storybook June 10, 2024 22:00 Inactive
@vercel vercel bot temporarily deployed to Preview – wri-terramatch-storybook June 11, 2024 12:56 Inactive
@vercel vercel bot temporarily deployed to Preview – wri-terramatch-storybook June 11, 2024 14:34 Inactive
@vercel vercel bot temporarily deployed to Preview – wri-terramatch-storybook June 11, 2024 14:57 Inactive
roguenet
roguenet approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@roguenet roguenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to merge once the build is passing (I'll go review that BE PR next to unblock this)

@cesarLima1 cesarLima1 merged commit 31fe307 into staging Jun 11, 2024
4 checks passed
@cesarLima1 cesarLima1 deleted the feat/TM-850-polygon-functionality branch June 11, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diego-morales-flores-1996 diego-morales-flores-1996 diego-morales-flores-1996 left review comments

@dottyy dottyy dottyy left review comments

@egrojMonroy egrojMonroy egrojMonroy left review comments

@roguenet roguenet roguenet approved these changes

Assignees

@dottyy dottyy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cesarLima1 @roguenet @egrojMonroy @dottyy @diego-morales-flores-1996