Skip to content

Commit

Permalink
[TM-1531] remove useless code, id in user, and rollback comment
Browse files Browse the repository at this point in the history
  • Loading branch information
egrojMonroy committed Dec 9, 2024
1 parent 3974e3c commit 389299d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 8,977 deletions.
5 changes: 4 additions & 1 deletion apps/job-service/src/jobs/delayed-jobs.controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export class DelayedJobsController {
): Promise<JsonApiDocument> {
const runningJobs = await DelayedJob.findAll({
where: {
isCleared: 0,
isCleared: false,
createdBy: authenticatedUserId
},
order: [['createdAt', 'DESC']],
Expand All @@ -52,6 +52,9 @@ export class DelayedJobsController {
@ApiException(() => NotFoundException, {
description: 'Job with that UUID not found.',
})
// Note: Since jobs are very generic and we don't track which resources are related to a given
// job, there is no effective way to make a policy for jobs until we expand the service to
// include an owner ID on the job table.
async findOne(@Param('uuid') pathUUID: string): Promise<JsonApiDocument> {
const job = await DelayedJob.findOne({ where: { uuid: pathUUID } });
if (job == null) throw new NotFoundException();
Expand Down
4 changes: 1 addition & 3 deletions libs/common/src/lib/dto/user.dto.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,5 @@ export class UserDto extends JsonApiAttributes<UserDto> {

@ApiProperty({ type: () => UserFramework, isArray: true })
frameworks: UserFramework[];

@ApiProperty({ nullable: true })
id: number | null;

}
Loading

0 comments on commit 389299d

Please sign in to comment.