GTC-2734 Add JRC/SBTN, confidence levels, and total_ha to integrated alerts #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alerts. For daily alerts, add new columns that divide the daily alerts into a 3x3 cross-product of (whole area, SBTN forest only, JRC forest only) x (lo, med, hi) alert confidence Also, add a new 'total_ha' column which is the area of the location. This area will be used by the front-end to calculate measures such as "daily alerts per hectare". Currently, I am calculating the entire location area in the usual per-pixel way with Geodesy.pixelArea. We were already calculating the area per pixel whenever isTreeCoverExtent30 was true (more than 30% tree cover). From a look at some input sets, it seems like this is usually a large part of the location areas. So, doing the area calculation for the entire geometry shouldn't be much more expensive. However, I will make sure that the isTreeCoverExtent30 area is a large part of the whole area for most datasets, once this change is in. If it is not, then it may give better performance to calculate the total area of locations outside of the pixel function using an equal-area projection (for which I already have some working code).
jterry64
requested changes
May 1, 2024
src/main/scala/org/globalforestwatch/summarystats/gfwpro_dashboard/GfwProDashboardData.scala
Outdated
Show resolved
Hide resolved
Changes based on Justin's comments. Also, I duplicated the glad_alerts_coverage column to integrated_alerts_coverage, based on Kinshuk's suggestion. He is hoping that we can just remove all the glad_alerts_* columns asynchronously once the UI has switched to using only the integrated_alerts_* columns. (The weekly and month alerts won't be needed anymore).
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 23.12% 23.77% +0.64%
==========================================
Files 297 297
Lines 6663 6721 +58
==========================================
+ Hits 1541 1598 +57
- Misses 5122 5123 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jterry64
previously approved these changes
May 7, 2024
This is in accordance with terminology for Flagship (though "nominal" is sometimes specified as "Detected by a single alert system"). Changed both the enum and the associated column names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTC-2734 Add JRC/SBTN, confidence levels, and total_ha to integrated alerts
For daily alerts, add new columns that divide the daily alerts into a 3x3 cross-product of (whole area, SBTN forest only, JRC forest only) x (lo, med, hi) alert confidence
Also, add a new 'total_ha' column which is the area of the location. This area will be used by the front-end to calculate measures such as "daily alerts per hectare".
Currently, I am calculating the entire location area in the usual per-pixel way with Geodesy.pixelArea. We were already calculating the area per pixel whenever isTreeCoverExtent30 was true (more than 30% tree cover). From a look at some input sets, it seems like this is usually a large part of the location areas. So, doing the area calculation for the entire geometry shouldn't be much more expensive.
However, I will make sure that the isTreeCoverExtent30 area is a large part of the whole area for most datasets, once this change is in. If it is not, then it may give better performance to calculate the total area of locations outside of the pixel function using an equal-area projection (for which I already have some working code).