GTC-2570 Filter out rows not requiring analysis #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jterry64
requested changes
Sep 18, 2023
| @@ -48,6 +48,8 @@ object AFiAnalysis extends SummaryAnalysis { | |||
| val summaryDF = AFiAnalysis.aggregateResults( | |||
| AFiDF | |||
| .getFeatureDataFrame(summaryRDD, spark) | |||
| .filter($"location_id" =!= -2) | |||
There was a problem hiding this comment.
I think actually we'd want to filter out -2 before we run the analysis, since the first time a user runs this, -2 will be the same as -1, a huge dissolved polygon. So kind of a waste to compute all that and then toss it away. You could run this same filter but for the input feature DF.
Codecov ReportPatch has no changes to coverable lines. ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know!. |
jterry64
requested changes
Sep 19, 2023
| @@ -40,5 +40,7 @@ object AFiDF extends SummaryDF { | |||
| } | |||
| .toDF("id", "error", "dataGroup", "data") | |||
| .select($"id.*", $"error.*", $"dataGroup.*", $"data.*") | |||
| .filter($"location_id" =!= -2) | |||
There was a problem hiding this comment.
Sorry, should've been clearer: we should filter these out at the very beginning, like if AFiCommand class, before we even run the analysis.
jterry64
approved these changes
Sep 27, 2023
solomon-negusse
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Performs analysis for difference geometries and areas with null GADM values
Issue Number: GTC-2570
What is the new behavior?
location_id = -2gadm_id = "null"Does this introduce a breaking change?
Other information