Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce UV to replace Pipenv; multi-stage Dockerfile #612

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

dmannarino
Copy link
Member

@dmannarino dmannarino commented Dec 6, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Using pipenv

Issue Number: N/A

What is the new behavior?

Pipenv replaced with uv

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.07%. Comparing base (dd0616e) to head (ed5569b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #612   +/-   ##
========================================
  Coverage    81.07%   81.07%           
========================================
  Files          130      130           
  Lines         5876     5876           
========================================
  Hits          4764     4764           
  Misses        1112     1112           
Flag Coverage Δ
unittests 81.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmannarino dmannarino marked this pull request as ready for review December 17, 2024 18:14
Copy link
Collaborator

@danscales danscales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I assuming this is faster/more reliable/easier to maintain with uv than with pip/pipenv.

Just had a few questions/minor requests.

FROM ubuntu:noble
SHELL ["sh", "-exc"]

ENV PATH=$VIRTUAL_ENV/bin:/usr/local/bin:$PATH
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking - are all the environment variables (especially VIRTUAL_ENV) that were set during the build stage, also automatically set in the same way for the runtime stage? I guess so, since otherwise tests wouldn't work, but it seems surprising, since you don't really want some of the build env variables set in the runtime docker.

]

[dependency-groups]
dev = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you dropped some packages under dev-packages in Pipfile, like asgi_lifespan, black, detect-secrets, and flake8. Just checking, was that on purpose?

[dependency-groups]
dev = [
"docker",
"geopandas",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You dropped some comments from the Pipfile for geopandas, gfw_pixetl, pandas, and retrying. Maybe add those comments back her in this file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants