Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cif 286 cams #86

Merged
merged 16 commits into from
Nov 7, 2024
Merged

Cif 286 cams #86

merged 16 commits into from
Nov 7, 2024

Conversation

weiqi-tori
Copy link
Member

@weiqi-tori weiqi-tori requested a review from tedw0ng October 18, 2024 08:35
@tedw0ng
Copy link
Member

tedw0ng commented Oct 23, 2024

Suggest having init require pollutant species. Then data query from API can just retrieve that pollutant, and also pressure and temp if the species is anything other than particulate matter.

If species is other than particulate matter, there should be a unit conversion before the result is returned. Conversion method is
concentration x pressure / (287.058 * temp) * 10^9

This is because these pollutants are kg/kg in CAMS. Conversion turns it into ug/m3.

Particulate matter should be conc * 10^9. This is because pm is in kg/m3 in CAMS, but we want ug/m3.

@tedw0ng
Copy link
Member

tedw0ng commented Oct 23, 2024

As per our meeting, pls ignore my request to have user specify pollutant species.

@tedw0ng
Copy link
Member

tedw0ng commented Oct 28, 2024

I'm getting NaNs for the concentration values when I run get_data().
See this notebook: https://github.com/wri/cities_data_misc/blob/main/indicator_reference_notebooks/cams_test.ipynb

@weiqi-tori weiqi-tori merged commit c270fd0 into main Nov 7, 2024
1 check passed
@weiqi-tori weiqi-tori deleted the CIF-286-CAMS branch November 7, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants