Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work on expanding coverage. #59

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

kcartier-wri
Copy link
Contributor

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • Yes, the URL of the associated JIRA ticket is https://gfw.atlassian.net/browse/CIF-XXX. The PR name follows the format [CIF-XXX] my subject.

  • No, this is a documentation update. The PR name follows the format [DOCS] my subject.

What changes were proposed in this PR?

How was this patch tested?

Did this PR include necessary documentation updates?

  • Yes, I am adding a new API feature.
  • Yes, I have updated the documentation update.
  • No, this PR does not affect any public API so no need to change the docs.

@kcartier-wri kcartier-wri marked this pull request as ready for review August 9, 2024 21:15
@kcartier-wri kcartier-wri requested review from chrowe and jterry64 August 9, 2024 21:16
Copy link
Member

@jterry64 jterry64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Just to make sure I understand since there was some refactoring too, you just made sure there was a test for each layer we have?

@kcartier-wri kcartier-wri merged commit cd7cd51 into main Aug 12, 2024
1 check passed
@kcartier-wri kcartier-wri deleted the CIF-247-Increase-unit-test-coverage-for-CIF branch August 12, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants