update setup #54
update setup #54
Conversation
setup.py
Outdated
| package_data={ | ||
| 'city_metrix.models.building_classifier': [ | ||
| 'building_classifier.pkl', | ||
| 'V2-building-class-data.geojson', |
There was a problem hiding this comment.
@chrowe was wondering if the user needs this file for running the package? Also, could you rename is to something more like building-class-data-v2.geojson?
There was a problem hiding this comment.
The user needs building_classifier.pkl to generate the SmartSurfaceLULC layer, but the geojson is not necessary. The geojson is the training data for building_classifier.pkl that I got from Elizabeth, I removed it for now.
setup.py
Outdated
| @@ -21,5 +28,10 @@ | |||
| "osmnx", | |||
| "geopandas", | |||
| "s3fs", | |||
| "dask==2023.11.0", | |||
There was a problem hiding this comment.
it might not be good to pin a specific version, it will fail if the user has another version. You can set a minimum though, like dask>=2023.11.0
There was a problem hiding this comment.
also, I think the conflict is from odc-stac above, not dask specifically. You can safely remove that, but will need to delete files that reference it
There was a problem hiding this comment.
odc-stac is used in landsat_collection_2.py and sentinel_2_level_2.py. We probably cannot remove that without updating the layers.
|
@weiqi-tori can you also remove |
|
FWIW, a quick search lead me to https://stackoverflow.com/questions/63342686/packaging-libraries-with-ml-models-in-python and not much else on the topic of how to include models in packages. Seems like they are recommending the same basic approach we took. |
JIRA ticket https://gfw.atlassian.net/browse/CIF-202