[CIF-160] Group by a categorical raster like LULC #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiqi-tori
approved these changes
Mar 4, 2024
chrowe
requested changes
May 23, 2024
.gitignore
Outdated
| @@ -163,3 +163,6 @@ cython_debug/ | |||
| /keys | |||
| keys/ | |||
| wri-gee-358d958ce7c6.json | |||
|
|
|||
| # notebooks, you need to `git add -f` to force them to be changed | |||
| .ipynb | |||
There was a problem hiding this comment.
Is there a reason for this?
There was a problem hiding this comment.
Not sure what happened here, but when I open this I see an an empty notebook.
|
|
||
| # align to highest resolution raster, which should be the largest raster | ||
| # since all are clipped to the extent | ||
| raster_data = [data for data in mask_datum + [aggregate_data] if isinstance(data, xr.DataArray)] | ||
| raster_data = [data for data in mask_datum + [aggregate_data] + [layer_data] if isinstance(data, xr.DataArray)] | ||
| align_to = sorted(raster_data, key=lambda data: data.size, reverse=True).pop() |
There was a problem hiding this comment.
Isn't this going to return the smallest since pop() gets the last item and you are sorting them in reverse order?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Besides grouping your results by a GeoDataFrame, allow grouping additionally by a categorical raster such as as a land use/land cover (LULC) layer. The results will be return as a dictionary for each zone of categorical value to the statistics. See the tests for examples.
How was this patch tested?
Unit tests were added to cover this case
Did this PR include necessary documentation updates?