Security hardending. Prevent empty array search. wpsharks/comment-mai…

…l#85
wpsharks · Jun 5, 2015 · 6226987 · 6226987
1 parent 9a7c9a7
commit 6226987
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/comment-mail-pro/includes/classes/utils-sub.php b/comment-mail-pro/includes/classes/utils-sub.php
@@ -607,7 +607,9 @@ public function query_total($post_id = NULL, array $args = array())
 					       ? ($sub_email_or_user_ids // Email or user IDs?
 						       ? " AND (`email` = '".esc_sql($sub_email)."'".
 						         (isset($user_id) ? " OR `user_id` = '".esc_sql($user_id)."'" : '').
-						         "    OR `user_id` IN('".implode("','", array_map('esc_sql', $this->email_user_ids($sub_email, $no_cache)))."'))"
+						         (($_sub_email_user_ids = $this->email_user_ids($sub_email, $no_cache))
+						             ? " OR `user_id` IN('".implode("','", array_map('esc_sql', $_sub_email_user_ids))."')"
+						             : '').')' // ↑ Only if we DO have user IDs to look for.
 						       : " AND `email` = '".esc_sql($sub_email)."'")
 					       : ''). // End `sub_email` check.