Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build frontend in artifact action and not frontend testing action #3

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Build frontend in artifact action and not frontend testing action #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b6c246
Build frontend in artifact action and not frontend testing action
wpears Sep 14, 2023
2f8ed5a
Merge branch 'master' into fe-and-artifact
wpears Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/workflows/build-artifact.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,16 @@ jobs:
- name: Check out the repo
uses: actions/checkout@v3

- name: Download artifact
uses: dawidd6/[email protected]
- name: Set up Node
uses: actions/setup-node@v3
with:
workflow: frontend.yml
commit: ${{ github.sha }}
name: frontend_${{ github.sha }}
node-version: '16.x'

- name: Install dependencies
run: yarn

- name: Build frontend
run: yarn run build

- name: Run the build process with Docker
uses: addnab/docker-run-action@v3
Expand Down
12 changes: 1 addition & 11 deletions .github/workflows/frontend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ jobs:
node-version: '16.x'

- name: Install dependencies
run: |
yarn
run: yarn

- name: Test Javascript
run: yarn run test
Expand All @@ -29,15 +28,6 @@ jobs:
name: frontend_coverage
path: ./test/unit_test_coverage/clover.xml

- name: Build Javascript
run: yarn build

- name: Upload artifact
uses: actions/upload-artifact@v3
with:
name: frontend_${{ github.sha }}
path: ./cfgov/static_built/

coverage:
runs-on: ubuntu-latest
needs:
Expand Down
Loading