Skip to content

Commit

Permalink
chore(blp): remove unnecessary exposure of mips boolean
Browse files Browse the repository at this point in the history
  • Loading branch information
fallenoak committed Dec 12, 2023
1 parent 9c1882b commit 1b16ca2
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 15 deletions.
7 changes: 0 additions & 7 deletions src/lib/blp/Blp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class Blp {
#colorFormat = BLP_COLOR_FORMAT.COLOR_DXT;
#alphaSize = 0;
#preferredFormat = BLP_PIXEL_FORMAT.PIXEL_DXT5;
#hasMips = 0;
#width = 0;
#height = 0;
#images: Uint8Array[] = [];
Expand Down Expand Up @@ -54,7 +53,6 @@ class Blp {
this.#colorFormat = header.colorFormat;
this.#alphaSize = header.alphaSize;
this.#preferredFormat = header.preferredFormat;
this.#hasMips = header.hasMips;
this.#width = header.width;
this.#height = header.height;

Expand Down Expand Up @@ -101,10 +99,6 @@ class Blp {
return this.#alphaSize;
}

get hasMips() {
return this.#hasMips;
}

get width() {
return this.#width;
}
Expand Down Expand Up @@ -297,7 +291,6 @@ class Blp {
this.#colorFormat = BLP_COLOR_FORMAT.COLOR_DXT;
this.#preferredFormat = BLP_PIXEL_FORMAT.PIXEL_DXT5;
this.#alphaSize = 0;
this.#hasMips = 0;
this.#width = 0;
this.#height = 0;
this.#images = [];
Expand Down
8 changes: 0 additions & 8 deletions src/spec/blp/Blp.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ describe('Blp', () => {
expect(blp.formatVersion).toBe(1);
expect(blp.colorFormat).toBe(BLP_COLOR_FORMAT.COLOR_PAL);
expect(blp.alphaSize).toBe(0);
expect(blp.hasMips).toBe(1);
expect(blp.width).toBe(512);
expect(blp.height).toBe(512);
});
Expand All @@ -27,7 +26,6 @@ describe('Blp', () => {
expect(blp.formatVersion).toBe(1);
expect(blp.colorFormat).toBe(BLP_COLOR_FORMAT.COLOR_PAL);
expect(blp.alphaSize).toBe(1);
expect(blp.hasMips).toBe(1);
expect(blp.width).toBe(32);
expect(blp.height).toBe(32);
});
Expand All @@ -42,7 +40,6 @@ describe('Blp', () => {
expect(blp.formatVersion).toBe(1);
expect(blp.colorFormat).toBe(BLP_COLOR_FORMAT.COLOR_PAL);
expect(blp.alphaSize).toBe(4);
expect(blp.hasMips).toBe(1);
expect(blp.width).toBe(128);
expect(blp.height).toBe(128);
});
Expand All @@ -57,7 +54,6 @@ describe('Blp', () => {
expect(blp.formatVersion).toBe(1);
expect(blp.colorFormat).toBe(BLP_COLOR_FORMAT.COLOR_PAL);
expect(blp.alphaSize).toBe(8);
expect(blp.hasMips).toBe(1);
expect(blp.width).toBe(128);
expect(blp.height).toBe(64);
});
Expand All @@ -72,7 +68,6 @@ describe('Blp', () => {
expect(blp.formatVersion).toBe(1);
expect(blp.colorFormat).toBe(BLP_COLOR_FORMAT.COLOR_DXT);
expect(blp.alphaSize).toBe(1);
expect(blp.hasMips).toBe(1);
expect(blp.width).toBe(16);
expect(blp.height).toBe(16);
});
Expand All @@ -87,7 +82,6 @@ describe('Blp', () => {
expect(blp.formatVersion).toBe(1);
expect(blp.colorFormat).toBe(BLP_COLOR_FORMAT.COLOR_DXT);
expect(blp.alphaSize).toBe(8);
expect(blp.hasMips).toBe(1);
expect(blp.width).toBe(256);
expect(blp.height).toBe(256);
});
Expand All @@ -102,7 +96,6 @@ describe('Blp', () => {
expect(blp.formatVersion).toBe(1);
expect(blp.colorFormat).toBe(BLP_COLOR_FORMAT.COLOR_DXT);
expect(blp.alphaSize).toBe(8);
expect(blp.hasMips).toBe(1);
expect(blp.width).toBe(512);
expect(blp.height).toBe(512);
});
Expand All @@ -117,7 +110,6 @@ describe('Blp', () => {
expect(blp.formatVersion).toBe(1);
expect(blp.colorFormat).toBe(BLP_COLOR_FORMAT.COLOR_RAW);
expect(blp.alphaSize).toBe(136);
expect(blp.hasMips).toBe(0);
expect(blp.width).toBe(256);
expect(blp.height).toBe(256);
});
Expand Down

0 comments on commit 1b16ca2

Please sign in to comment.