Node: p2p.Run not always subscribing to heartbeat channel when it should #4152
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
force-pushed
the
node_p2p_run_not_always_subscribing_to_hb_when_it_should
branch
from
09ac0c1
to
daf8d3a
Compare
bruce-riley
requested review from
evan-gray,
panoel and
SEJeff
as code owners
panoel
approved these changes
Nov 4, 2024
SEJeff
approved these changes
Nov 5, 2024
bruce-riley
deleted the
node_p2p_run_not_always_subscribing_to_hb_when_it_should
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
p2p.Runmethod is not subscribing to the channel topic if a client (such as the historical uptime monitor) subscribes to heartbeats via the guardian set state but not any other of the other events that use the control topic. This results in never seeing heartbeats.I tested this by hacking the spy to subscribe to heartbeats using the guardian set state.