node: add amazon kms and benchmark signers (old) #4148
Closed
+585
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pires
reviewed
Oct 31, 2024
pires
reviewed
Nov 19, 2024
pires
reviewed
Nov 20, 2024
| guardianSignerUri := args[0] | ||
| wormchainAddress := args[1] | ||
| if !strings.HasPrefix(wormchainAddress, "wormhole") || strings.HasPrefix(wormchainAddress, "wormholeval") { | ||
| return errors.New("must provide a bech32 address that has 'wormhole' prefix") | ||
| } | ||
|
|
||
| guardianSigner, err := guardiansigner.NewGuardianSignerFromUri(guardianSignerUri, *unsafeDevnetMode) | ||
| guardianSigner, err := guardiansigner.NewGuardianSignerFromUri(ctx, guardianSignerUri, *unsafeDevnetMode) |
There was a problem hiding this comment.
Context shouldn't be passed to constructors but to calls, such as Sign and Verify by the callers.
- https://go.dev/blog/context-and-structs#prefer-contexts-passed-as-arguments
- https://go.dev/blog/context-and-structs#storing-context-in-structs-leads-to-confusion
That said, I think we can keep this as is and simply add comments explaining why this is a special case, i.e. you need a context for calling AWS KMS during signer initialization.
There was a problem hiding this comment.
Alternatively, the initialization may not ask for a parent Context and simply manage its own, e.g. a Context.WithTimeout(timeout) should suffice.
There was a problem hiding this comment.
I think the suggestion for managing its own context is good. But I'm on the fence about it, so I'm going to defer this to a broader review for the time being.
pleasew8t
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazon KMS Guardian Signer
This PR adds an Amazon AWS KMS Guardian signer, allowing observations to be signed using KMS! The new signer can be used by specifying the ARN of the KMS key to use, through the
--guardianSignerUricommandline argument, as follows:--guardianSignerUri=amazonkms://<ARN>NOTE For the best possible performance, it is recommended that the Guardian be run from an EC2 instance that is in the same region as the KMS key.
The KMS key's spec should be
ECC_SECG_P256K1, and should be enabled for signing. In order for the Guardian to authenticate against the KMS service, one of two options are available:~/.aws/credentialsfile. (example here).