Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients/js: add chain and rpc support for worm verify-vaa command #3951

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

HamphreyR26
Copy link
Contributor

Changes

  • Added --rpc, --chain and --contract-address args to worm verify-vaa command
  • Updated README.md

@HamphreyR26 HamphreyR26 changed the title clients/js: add chain and rpc support for command clients/js: add chain and rpc support for \worm verify-vaa\ command May 28, 2024
@HamphreyR26 HamphreyR26 changed the title clients/js: add chain and rpc support for \worm verify-vaa\ command clients/js: add chain and rpc support for worm verify-vaa command May 28, 2024
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails some checks. Please fix them. Also could you provide the motivation for verifying a VAA against the other EVM core bridges? The result should be identical as long as they are on the same guardian set.

@HamphreyR26
Copy link
Contributor Author

I'm sorry for keeping you waiting for so long. I wrote this code for my own purposes during researching smart contracts. I use it for verifing VAAs on a hardhat fork. I think it might be useful for someone else as well. JS is not my strong suit, sorry for any inconvenience caused. Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants