Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tilt: speedier ci #572

Merged
merged 6 commits into from
Dec 4, 2024
Merged

Conversation

evan-gray
Copy link
Contributor

@evan-gray evan-gray commented Dec 4, 2024

This PR makes several speed improvements to the tilt tests.

Initially, the test suite took about 530 seconds. That's nearly 9 minutes!

  1. The tests had a 1 minute sleep on relays, but after evm: pass consistencyLevel to WormholeRelayer during send #538 the relay uses the same consistency level (200 = instant) so that's no longer necessary. New time 400s, about 130s savings.
  2. Switch the Solana consistency level to Confirmed when one of the tilt feature flags is enabled. New time 320s, about 80s savings.
  3. Batch the accountant VAAs - they need to be in a particular order, but there's no reason not to submit them all in the same transaction as long as it's not above the gas limit. New time 280s, about 40s savings.
  4. Parallelize the peer setup - each chain's transactions are run sequentially with a single wallet, but those can be done in parallel. New time 220s, about 60s savings.
  5. Parallelize tests - I initially split it into two files, but it seemed a little easier to split into one for now. The code changes accommodate either approach. The run time was the about the same either way, except I got an open handle with the separate files. New time 120s, about 100s savings.

Now the tests take just about 2 minutes, or less than a quarter of the original time!

This also avoids building all of the monorepo Solana contracts and simply starts with the end result of having a core bridge with its accounts, the rest of the programs and accounts weren't used anyway. In a future PR, I would like to similarly improve EVM and Wormchain.

@evan-gray evan-gray changed the title Speedier ci tilt: speedier ci Dec 4, 2024
Copy link
Collaborator

@johnsaigle johnsaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements, I think the only thing to consider is that we'll need to update bridge.so here if there's ever a bridge update, otherwise we'll be testing against an old version.

@evan-gray
Copy link
Contributor Author

Nice improvements, I think the only thing to consider is that we'll need to update bridge.so here if there's ever a bridge update, otherwise we'll be testing against an old version.

That's correct, though any breakage of the core bridge would break all integrators, so I figured that was a safe-enough assumption to make. I plan to have a similar approach to speed up eth-devnet and may re-organize and document this there.

@evan-gray evan-gray merged commit 9c5276f into wormhole-foundation:main Dec 4, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants