sdk: quote destination amount truncation fix #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kev1n-peters
commented
Nov 28, 2024
| // remove dust to avoid `TransferAmountHasDust` revert reason | ||
| const truncatedAmount = amount.truncate( | ||
| amt, | ||
| Math.min(amt.decimals, dstTokenDecimals, NttRoute.TRIMMED_DECIMALS) |
There was a problem hiding this comment.
Fixes an issue where calling quote with an amount that has more fractional digits than the destination chain supports throws an error. We need to truncate and scale the destination amount to destination chain decimals.
kev1n-peters
force-pushed
the
dst-amount-truncate-fix
branch
from
d0c7a9f
to
1688e1d
Compare
nvsriram
approved these changes
Nov 29, 2024
artursapek
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where calling quote with an amount that has more fractional digits than the destination chain supports throws an error. We need to truncate and scale the destination amount to destination chain decimals (min(srcDecimals, dstDecimals, 8). If the transfer amount has dust, the contract will revert:
native-token-transfers/evm/src/NttManager/NttManager.sol
Line 680 in ef24f9f