solana: add recovery flow #418
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The associated token program instructions default to the legacy SPL token program. We pass the token_program as an argument to support token2022 tokens too.
TODO: the old token program still works -- is this secure? I think so but double check
to be able to test if it was executed
kcsongor
force-pushed
the
solana/recovery
branch
2 times, most recently
from
abe704d
to
233aea6
Compare
wip because with this the test tx size is 5 bytes larger (for transfer) than the limit. The way to mitigate is to introduce lookup tables. That mitigation will exist in the tests, but will also have to be done on real deployments (since the transfer hooks might add an arbitrary number of extra acconuts, so we should leave as much headroom as possible)
kcsongor
force-pushed
the
solana/recovery
branch
2 times, most recently
from
b3ab0ae
to
82f9e94
Compare
kcsongor
force-pushed
the
solana/token22
branch
from
cfeeccb
to
a3ccab3
Compare
kcsongor
force-pushed
the
solana/recovery
branch
from
82f9e94
to
18ebdc1
Compare
kcsongor
commented
Apr 23, 2024
| @@ -9,15 +9,17 @@ crate-type = ["cdylib", "lib"] | |||
| name = "example_native_token_transfers" | |||
|
|
|||
| [features] | |||
| default = ["mainnet"] | |||
| default = ["owner-recovery", "mainnet"] | |||
There was a problem hiding this comment.
should remove this by default (mainnet too)
kcsongor
force-pushed
the
solana/token22
branch
from
a3ccab3
to
e7eca16
Compare
|
We've had some discussions about whether or not this should be included, and are currently thinking that this functionality could be provided to integrators directly instead of existing in the main reference repo. |
kcsongor
force-pushed
the
solana/token22
branch
5 times, most recently
from
0e19d3c
to
bf49cab
Compare
kcsongor
force-pushed
the
solana/token22
branch
4 times, most recently
from
c8bc683
to
4b564c0
Compare
johnsaigle
force-pushed
the
solana/token22
branch
from
4b564c0
to
a72e72f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
recovery.rsfor an explanation of the flow.