Fix finalization for offchain mode. #831
Merged
+23
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dzejkop
reviewed
Dec 2, 2024
piohei
force-pushed
the
piohei/fix_finalizing_roots_offchain
branch
from
bae12d3 to
15fa087
Compare
piohei
force-pushed
the
piohei/fix_finalizing_roots_offchain
branch
from
15fa087 to
c0ca8d4
Compare
Dzejkop
reviewed
Dec 2, 2024
| // It happens sometimes as we do not have atomic operation for database and tree | ||
| // insertion. | ||
| // TODO: check if this is still possible after HA being done | ||
| tx.commit().await?; |
There was a problem hiding this comment.
wouldn't rollback be more fitting here? Since we intend for nothing to happen?
There was a problem hiding this comment.
I would rather leave commit here as there was no error at all.
Dzejkop
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist