Version 1.0.0 #168
Merged
Version 1.0.0 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicknisi
approved these changes
Jan 13, 2025
| @@ -343,7 +343,7 @@ describe('session.ts', () => { | |||
| expect(console.log).toHaveBeenNthCalledWith( | |||
| 2, | |||
| 'Failed to refresh. Deleting cookie.', | |||
| new Error('Failed to refresh'), | |||
| new Error('Failed to refresh session: Failed to refresh'), | |||
There was a problem hiding this comment.
nit(non-blocking): this error message feels a little repetitive.
There was a problem hiding this comment.
I agree! It's not a "real" error message but one that we mock up on line 321. The real error message would (hopefully) be way more descriptive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1 release of authkit-next 🎉
This release includes:
AuthKitProviderin client components no longer breaks the buildThis PR also fixes 2 failing tests.