-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: expectAssertion updates for RFC 232 compat #21
base: async-wip
Are you sure you want to change the base?
Conversation
638da1d
to
9ecbb46
Compare
9ecbb46
to
3ec518d
Compare
I entered the repo looking for this. What is missing on this? May I help? |
@cibernox - Likely needs some "dusting off" and bug fixing (since CI is failing). I think the main changes to the |
@cibernox Hit a bit of a roadblock described here #18 (comment) and haven't had a chance to look at it again. Please work on it if you have some spare time, would love the help! |
@alexdiliberto @rwjblue I've started by an update-only PR (#23) to separate the wheat from the chaff. |
Hi guys! Any news about this issue? We're having problems with the function expectAssertion in our project. We're patching a Perhaps it would be convenient to update the async-wip branch with the @cibernox PR (#23) and separate the framework/CLI update from the adaptation to the RFC. Let me know if I can help in any way. Thanks in advance! |
I am upstreaming these assertions into ember-qunit I will review this PR, and try and incorporate appropriate changes upstream. When all this lands, my plan is to deprecate this library entirely in-favor of it's assertions simply being officially supported: #29 |
No description provided.