Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Overlay OnClickListener, PlayInSequence, Next method #16

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

aaronliew
Copy link
Collaborator

hihi,

Awesome library! Have a look at the changes!

Regards,
workerApe

@worker8
Copy link
Owner

worker8 commented Aug 1, 2015

Thanks for the many commits!

I realize that you are actually working on a few separate features that are not relevant to each other. Can you separate them into different branches and submit as different pull request?

The reason behind this is because there will be some back and forth, for example: I might have some feedback on commit 1, and you might need to do changes on commit 1, but commit 2 is ready to be merged, but I couldn't merge yet due to commit 1 still having to change.

Besides, it is easier for discussion when each relevant feature is in each individual branches, and also easier for me to understand your code.

From what I can see, you are working on:

  • Overlay listener feature
  • Convenience method for playing in sequence feature
  • Method to check if TourGuide is showing

So ideally you should have 3 branches and 3 pull requests (it is alright for feature and the relevant example to go under the same branch).

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants