updates to field logic and adding fK field on relationships #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bennettgo let me know your thoughts on this. |
bennettgo
reviewed
Aug 17, 2021
There was a problem hiding this comment.
@johnhuffmanattrackvia so sorry for the late review. A few comments
johnhuffmanattrackvia
force-pushed
the
update-field-logic
branch
from
1de1ad9 to
934c2fd
Compare
bennettgo
reviewed
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates how the output fields on a record are dynamically computed. It looks pretty intimidating but the logic is more straightforward I believe. The root reason for this was to add a new data pill for relationships that exposes the fK on the child record. This is already present in the API, but because of how the merge logic works, it was not exposed in workato because it was missing some merge criteria. I've tested all the actions and it seems to function correctly after updates.