Upgrade compile and target sdk version to Android API 34 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2024
geriux
approved these changes
May 17, 2024
There was a problem hiding this comment.
LGTM!
Tests were done using this Gutenberg PR and this generated build in WordPress Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is related to the upgrade effort to Android 14 in Gutenberg Mobile: wordpress-mobile/gutenberg-mobile#6533. It basically updates all references of
compileSdkVersionandtargetSdkVersionparameters to use version34.This change is similar to wordpress-mobile/react-native-slider#13.
Test plan
TBD