Add react-native-prompt-android package
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # build.gradle.kts # package-lock.json # package.json # settings.gradle.kts
fluiddot
force-pushed
the
add-react-native-prompt-android
branch
from
049cb3d to
7c6fd48
Compare
fluiddot
commented
Mar 10, 2022
Comment on lines
+105
to
+114
| // Extract version from filename of tarball URL | ||
| val isTarball = packageVersion.endsWith(".tgz") | ||
| if (isTarball) { | ||
| // Replace special characters of package name as "npm pack" command does, to be used in the filename. | ||
| // Reference: https://github.com/npm/cli/blob/699c2d708d2a24b4f495a74974b2a345f33ee08a/lib/pack.js#L66-L67 | ||
| val packageNameSanitized = jsonProperty.replace("@", "").replace("/", "-") | ||
| val fileName = packageVersion.substring(packageVersion.lastIndexOf("/") + 1) | ||
| val version = fileName.replace(packageNameSanitized + "-", "").replace(".tgz", "") | ||
| return version | ||
| } |
There was a problem hiding this comment.
This will calculate the version of the package from the tarball filename, as we do in Gutenberg (reference).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
react-native-prompt-androidpackage from its forked repository. For this case, I created a new branchwp-fork-only-android-changesthat contains only the changes required for that package (without the Android publishing logic).If we could also publish this type of dependencies via this repository, it would simplify the changes in the forked repositories and most likely, reduce the updates we have to do there, as most of the updates are related to the publishing logic.
NOTE: This PR also includes changes from #2.