Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Upgrade compile and target sdk version to Android API 33 #25

Merged
merged 6 commits into from
May 22, 2023

Conversation

fluiddot
Copy link

Description

This PR is related to the upgrade effort to Android 13 in Gutenberg Mobile: wordpress-mobile/gutenberg-mobile#5556. It basically updates all references of compileSdkVersion and targetSdkVersion parameters to use version 33.

This change is similar to when we upgrade to Android 12.

Test plan

This update can be tested using the Gutenberg editor and the following PR: WordPress/gutenberg#50731.
The idea would be to run smoke testing on the demo project in order to check that there are no issues with Android 13.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has been copied from the upstream repository: software-mansion@8d70e87

@fluiddot fluiddot force-pushed the update/android-13 branch from 022b08e to 1b0aff3 Compare May 18, 2023 14:09
@fluiddot fluiddot merged commit 2650817 into wp-fork-2.3.2 May 22, 2023
@fluiddot fluiddot deleted the update/android-13 branch May 22, 2023 11:54
@fluiddot
Copy link
Author

@geriux Note that this PR is merged into wp-fork-2.3.2 as the previous Android update was also made this way. I noticed that wp-fork uses version 2.5.0, however, I haven't found that it has ever been used in Gutenberg 🤔. Since you created this PR (probably related to an RN upgrade), do you know which version we should use? Thanks 🙇 !

@geriux
Copy link

geriux commented May 22, 2023

Oh yes! We had an issue on iOS where the editor would freeze so we decided to keep an older version, but the fork kept 2.5.0 so we should keep using 2.3.2 until we figure out those issues, possibly already fixed in a newer version of the library.

@fluiddot
Copy link
Author

Oh yes! We had an issue on iOS where the editor would freeze so we decided to keep an older version, but the fork kept 2.5.0 so we should keep using 2.3.2 until we figure out those issues, possibly already fixed in a newer version of the library

Ah, thanks for sharing the info. I'll add a note about this in the wp-fork PR as a warning for future changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants