Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.119.0 #6886

Merged
merged 5 commits into from
May 24, 2024
Merged

Release 1.119.0 #6886

merged 5 commits into from
May 24, 2024

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented May 23, 2024 •
edited
Loading

Release for Gutenberg Mobile 1.119.0

Related PRs

Changes

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

This was referenced May 23, 2024
Merged
Merged
@twstokes twstokes requested a review from geriux May 23, 2024 19:33
geriux
geriux approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@twstokes twstokes merged commit d21d463 into trunk May 24, 2024
23 checks passed
@twstokes twstokes deleted the release/1.119.0 branch May 24, 2024 18:06
@geriux
Copy link
Contributor

geriux commented May 28, 2024 •
edited
Loading

🟢 Basic Test Suite Checklist (iOS)

Build: 25.0.0.0 from TestFlight
Device: iPhone 15 Pro (OS 17.5.1)

Writing Flow

Rich Text Format

  • TC007 - Test format detection under the cursor
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading

Unsupported Block

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

Gallery Block

  • TC005 - Choose from device (stay in editor) - Successful upload

@geriux
Copy link
Contributor

geriux commented May 28, 2024 •
edited
Loading

🟢 Test Suite 5 (iOS)

Build: 25.0.0.0 from TestFlight
Device: iPhone 15 Pro (OS 17.5.1)

Video block - 1

  • Video block - Insert video from device (failing) - TC001
  • Video block - Close/Re-open post with an ongoing video upload - TC004

Video block - 2

  • Video block - Insert video from device (cancel) - TC002
  • Video block - Close post with an ongoing video upload - TC005
  • Video block - Add Caption - TC003

File block - 1

  • File block - Upload completes successfully from the device library - TC001
  • File block - Insert completes successfully from the WordPress Media library - TC002
  • File block - Upload fails from the device library - TC003
  • File block - Stop the file upload before it completes - TC004

File block - 2

  • File block - Close the post with an ongoing file upload - TC005
  • File block - Replace the selected files - TC006
  • File block - Change the alignment in the File Block - TC007
  • File block - The Link To Block Setting should open - TC008

File block - 3

  • File block - Open link in new tab - TC009
  • File block - Show/hide download button (Block Settings only) - TC010
  • File block - Copy file URL - TC011
  • File block - Close/Re-open post with an ongoing file upload - TC012

Audio block - 1

  • Audio block - Upload completes successfully from the device library - TC001
  • Audio block - Insert completes successfully from the WordPress Media library - TC002

Audio block - 2

  • Audio block - Upload fails from the device library - TC003
  • Audio block - Stop the audio file upload before it completes - TC004

Audio block - 3

  • Audio block - Close the post with an ongoing audio file upload - TC005
  • Audio block - Replace the selected files - TC006
  • Audio block - Change the alignment in the Audio Block - TC007

Audio block - 4

  • Audio block - Close/Re-open post with an ongoing audio file upload - TC010

Synced patterns - 1

  • Synced patterns - Add pattern - TC001
  • Synced patterns - Detach pattern - TC002

Synced patterns - 2

  • Synced patterns - Deleted pattern - TC003
  • Synced patterns - Recursive block rendering - TC004

Embed block - 1

  • Embed block - Inline previews are rendered correctly for the top 5 most-used providers - TC001

Embed block - 2

  • Embed block - Inline previews are rendered accordingly for each alignment option - TC002

@geriux
Copy link
Contributor

geriux commented May 28, 2024 •
edited
Loading

🟢 New changes (iOS)

Build: 25.0.0.0 from TestFlight
Device: iPhone 15 Pro (OS 17.5.1)

@twstokes
Copy link
Contributor Author

twstokes commented May 29, 2024 •
edited
Loading

🟡 Basic Test Suite Checklist (Android)

Build: 25.0-rc-1 from Google Play Beta
Device: Pixel 4a (Android 13)

Writing Flow

Rich Text Format

Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
      • ⚠️ After erasing the selected text hitting backspace did not merge the blocks.
    • Heading
      • ⚠️ After erasing the selected text hitting backspace did not merge the blocks.
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
      • ⚠️ The keyboard hid after inserting the blank block in between.
    • Heading
      • ⚠️ The keyboard hid after inserting the blank block in between.

Unsupported Block

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

Gallery Block

  • TC005 - Choose from device (stay in editor) - Successful upload

@twstokes
Copy link
Contributor Author

twstokes commented May 30, 2024 •
edited
Loading

⚠️ A few issues I'm investigating:

  • The first word of headings is erased if autocorrected
  • Creating a new heading is sometimes defaulting to <h2>
  • Sometimes a heading's font size is not reflected

@geriux
Copy link
Contributor

geriux commented May 30, 2024

The first word of headings is erased if autocorrected

I've been working on a fix for this in WordPress/gutenberg#59831 that would solve two issues WordPress/gutenberg#56608 and #3106

Sometimes a heading's font size is not reflected

We have an issue tracking this one WordPress/gutenberg#50673 but we haven't worked on it yet

@twstokes
Copy link
Contributor Author

Thanks @geriux! I had a feeling we'd already discussed these so I appreciate you providing the trail. I'll carry on with tests. 🚀

@twstokes
Copy link
Contributor Author

twstokes commented May 30, 2024 •
edited
Loading

🟡 New changes (Android)

Build: 25.0-rc-1 from Google Play Beta
Device: Pixel 4a (Android 13)

screen-20240530-211000.mp4

@twstokes
Copy link
Contributor Author

twstokes commented May 31, 2024 •
edited
Loading

🟢 Test Suite 4 (Android)

Build: 25.0-rc-1 from Google Play Beta
Device: Pixel 4a (Android 13)

Group - 2

  • Group - Check if nested Placeholder block can be replaced - TC010

Buttons - 4

  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - TC017

Buttons - 5

  • Buttons block - Render theme colors - TC015
  • Buttons block - Settings: Change Button border radius - TC011

Buttons - 7

  • Buttons block - Toolbar link button is active when Button has link - TC018

Editor Theme - 2

  • Custom Gradients - Check that custom gradients load in the editor - TC004
  • Offline Support - TC005

Color Settings - 2

  • Customize gradient color - TC005
  • Custom color picker - TC006

VideoPress - 1

  • VideoPress block - Upload a video - TC001
  • VideoPress block - Close post with an ongoing video upload - TC004

@twstokes
Copy link
Contributor Author

In WordPress 24.9 I re-tested TC002 and TC005:

  • TC002: I had the same issue where the blocks didn't merge, so this is not a regression with this release.
  • TC005: The keyboard did not hide, which is expected behavior.
    • I then tested 25.0-rc-1 again and the keyboard did not hide this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twstokes @geriux