Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Story block #6568

Merged
merged 11 commits into from
Jan 25, 2024
Merged

Remove Story block #6568

merged 11 commits into from
Jan 25, 2024

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jan 23, 2024 •
edited
Loading

Related PRs:

This PR removes the Story block.

To test

Story block can't be inserted

  1. Create a post.
  2. Tap on ➕ button.
  3. Scroll the block list and observe that the Story block is not displayed.
  4. Tpa on the Paragraph block.
  5. Type /story and observe that the Story block option is not displayed.

Story block is displayed as unsupported

  1. In the browser, create a post and insert a Story block.
  2. Go to the app and open the same post.
  3. Observe that the Story block is displayed as unsupported.
  4. Tap on the block and observe that it can still be edited via UBE (Unsupported Block Editor).

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

This was referenced Jan 23, 2024
Merged
Merged
Merged
Merged
@fluiddot fluiddot marked this pull request as ready for review January 25, 2024 14:54
@dcalhoun dcalhoun self-requested a review January 25, 2024 15:42
dcalhoun
dcalhoun approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test plan succeeded for me using an iPhone SE and Samsung Galaxy S20 with both the WordPress and Jetpack mobile apps.

@fluiddot fluiddot enabled auto-merge January 25, 2024 19:10
@fluiddot fluiddot merged commit 95d7d30 into trunk Jan 25, 2024
20 checks passed
@fluiddot fluiddot deleted the remove-story-block branch January 25, 2024 19:26
fluiddot added a commit that referenced this pull request Jan 26, 2024
@fluiddot
Merge pull request #6568 from wordpress-mobile/remove-story-block
9fe9630 
Remove Story block
# Conflicts:
#	gutenberg
#	jetpack
@fluiddot fluiddot mentioned this pull request Jan 26, 2024
Merged
4 tasks
This was referenced Jan 26, 2024
Closed
Closed
dcalhoun added a commit to wordpress-mobile/test-cases that referenced this pull request Feb 8, 2024
@dcalhoun
docs: Remove Story block test cases
6968140 
The Story block functionality was disabled in
wordpress-mobile/gutenberg-mobile#6568.
@dcalhoun dcalhoun mentioned this pull request Feb 8, 2024
Merged
dcalhoun added a commit to wordpress-mobile/test-cases that referenced this pull request Feb 8, 2024
@dcalhoun
docs: Remove Story block test cases (#167)
831dd9a 
The Story block functionality was disabled in
wordpress-mobile/gutenberg-mobile#6568.
@fluiddot fluiddot mentioned this pull request Mar 4, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees
No one assigned
Labels
Story block [Type] Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @dcalhoun