Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the SPM issue with ObjC headers in WPKit #23390

Closed
wants to merge 1 commit into from

Conversation

kean
Copy link
Contributor

@kean kean commented Jun 26, 2024

I don't think SWIFT_PACKAGE macro works in Objective-C headers, and that what was causing the problem. That was the only header file using it. No header – no problem.

Note: to fully work, it will also need this wordpress-mobile/WordPress-iOS-Shared#361 – WIP.

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean requested a review from jkmassel June 26, 2024 21:30
@dangermattic
Copy link
Collaborator

dangermattic commented Jun 26, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23390-9ed3e33
Version25.1
Bundle IDorg.wordpress.alpha
Commit9ed3e33
App Center BuildWPiOS - One-Offs #10231
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23390-9ed3e33
Version25.1
Bundle IDcom.jetpack.alpha
Commit9ed3e33
App Center Buildjetpack-installable-builds #9280
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean changed the title Add SPM support to WPKit Fix the SPM issue with ObjC headers in WPKit Jun 26, 2024
@kean kean closed this Jul 5, 2024
@kean kean deleted the task/add-spm-support-in-wpkit branch July 5, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants