Skip to content

Commit

Permalink
Merge pull request #350 from wordpress-mobile/iangmaia/swiftlint-vers…
Browse files Browse the repository at this point in the history
…ion-ci

Tooling: Define SwiftLint version
  • Loading branch information
iangmaia authored Feb 26, 2024
2 parents 2dc7b5d + 698cc6e commit a4179d3
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 35 deletions.
23 changes: 0 additions & 23 deletions .buildkite/commands/swiftlint.sh

This file was deleted.

19 changes: 7 additions & 12 deletions .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Nodes with values to reuse in the pipeline.
common_params:
plugins: &common_plugins
- automattic/a8c-ci-toolkit#3.0.1
- automattic/a8c-ci-toolkit#3.1.0
env: &common_env
IMAGE_ID: xcode-15.0.1

Expand Down Expand Up @@ -38,19 +38,14 @@ steps:
env: *common_env
plugins: *common_plugins

- label: ':swift: SwiftLint'
key: swiftlint
command: .buildkite/commands/swiftlint.sh --strict
agents:
queue: default
plugins:
- docker#v5.8.0:
# TODO: Ensure the same version as local is used, i.e. with Buildkite env vars injection during pipeline upload
image: ghcr.io/realm/swiftlint:latest
mount-buildkite-agent: true # Needed for calling `buildkite-agent annotate`
- label: ":swift: SwiftLint"
command: run_swiftlint --strict
plugins: *common_plugins
notify:
- github_commit_status:
context: SwiftLint
context: "SwiftLint"
agents:
queue: "default"

#################
# Publish the Podspec (if we're building a tag)
Expand Down
2 changes: 2 additions & 0 deletions .swiftlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
# While we figure that out, here is a copy of the remote configuration.
# Some of the custom rules are useless in this context, but we kept them to keep consistency for when we'll move back to it.

swiftlint_version: 0.54.0

# Project configuration
#
excluded:
Expand Down

0 comments on commit a4179d3

Please sign in to comment.