Adds new endpoint to update notification settings #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
JorgeMucientes
commented
Dec 30, 2024
| @@ -3,10 +3,7 @@ package org.wordpress.android.fluxc.network.rest.wpcom.notifications | |||
| import android.content.Context | |||
There was a problem hiding this comment.
Real changes start at line 393 of this file. The rest is just automatic code reformatting.
JorgeMucientes
commented
Dec 30, 2024
| @@ -14,12 +14,18 @@ import org.wordpress.android.fluxc.model.SiteModel | |||
| import org.wordpress.android.fluxc.model.notification.NoteIdSet | |||
There was a problem hiding this comment.
Same, real changes start at line 600 of this file. The rest is just automatic code reformatting.
JorgeMucientes
requested review from
hichamboushaba,
irfano and
hafizrahman
and removed request for
hichamboushaba
hafizrahman
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new endpoint to update (enable/disable) notification settings for a given device and
siteIds.Changes can be tested in this PR where the endpoint is used to disable notification for unslected sites.