Non-static locale

[nbradbury]

This PR addresses this comment regarding LocaleManager by removing LocaleManager.getLanguage() and replacing it with PerAppLocaleManager.getCurrentLocaleLanguageCode().

@ParaskP7 I've asked for your review of this since you're familiar with the context, but there's no rush to get this merged. Also, I see that this is failing SonarCloud Code Analysis due to duplication, but I'm thinking we can ignore that 🤞

[dangermattic]

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21549-3e407f7
	Commit	3e407f7
	Direct Download	wordpress-prototype-build-pr21549-3e407f7.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21549-3e407f7
	Commit	3e407f7
	Direct Download	jetpack-prototype-build-pr21549-3e407f7.apk

Note: Google Login is not supported on these builds.

[sonarqubecloud]

Quality Gate failed

Failed conditions
12.0% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 39.48%. Comparing base (01f6aca) to head (3e407f7).
Report is 6 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...d/ui/reader/services/search/ReaderSearchLogic.java	0.00%	3 Missing ⚠️
...droid/ui/reader/repository/ReaderPostRepository.kt	0.00%	2 Missing ⚠️
...ui/reader/services/discover/ReaderDiscoverLogic.kt	0.00%	2 Missing ⚠️
...s/android/push/NotificationsProcessingService.java	0.00%	1 Missing ⚠️
...reader/services/search/ReaderSearchJobService.java	0.00%	1 Missing ⚠️
...ui/reader/services/search/ReaderSearchService.java	0.00%	1 Missing ⚠️
...d/ui/reader/services/update/ReaderUpdateLogic.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #21549   +/-   ##
=======================================
  Coverage   39.48%   39.48%           
=======================================
  Files        2117     2117           
  Lines       99464    99464           
  Branches    15296    15296           
=======================================
  Hits        39269    39269           
  Misses      56714    56714           
  Partials     3481     3481           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ParaskP7]

👋 @nbradbury !

I have reviewed this PR as per the instructions (also tested it), everything works as expected, thanks for making this refactor! 🥇

Also, I see that this is failing SonarCloud Code Analysis due to duplication, but I'm thinking we can ignore that 🤞

Definitely can ignore that. 👍

[nbradbury]

@ParaskP7 You surprised me by reviewing this so quickly - thank you!

[ParaskP7]

😅 I would have been now or 2 weeks from now! 😅