-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Gravatar SDK to 2.2.0 #21544
Bump Gravatar SDK to 2.2.0 #21544
Conversation
android:maxSdkVersion="29" /> | ||
android:maxSdkVersion="29" | ||
tools:replace="android:maxSdkVersion" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already mentioned in the description, but I'm pasting it here as well to make sure it's not missed.
You can see that I had to add tools:replace="android:maxSdkVersion"
to the AndroidManifest.xml
. This ensures that no changes to the WP manifest are done and the maxSdkVersion=29
is kept. Quick Editor needs the android.permission.WRITE_EXTERNAL_STORAGE
permission but only up to API 28, so that's where the conflict is. This permission is needed for the DownloadManager (see docs) to download Avatars.
Here's a screenshot of the merge AndroidManifest from the .apk confirming no changes are made.
Quality Gate passedIssues Measures |
Project dependencies changesThe following changes in project dependencies were detected (configuration list
tree-+--- project :libs:image-editor
-| \--- com.google.android.material:material:1.12.0
-| \--- org.jetbrains.kotlin:kotlin-bom:1.8.22
-| \--- org.jetbrains.kotlin:kotlin-reflect:1.8.22 (c)
++--- project :libs:login
+| \--- com.gravatar:gravatar:2.2.0
+| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.25 -> 2.0.21 (*)
+| +--- com.squareup.retrofit2:retrofit:2.11.0
+| | \--- com.squareup.okhttp3:okhttp:3.14.9 -> 4.12.0 (*)
+| +--- com.squareup.retrofit2:converter-moshi:2.11.0
+| | +--- com.squareup.retrofit2:retrofit:2.11.0 (*)
+| | \--- com.squareup.moshi:moshi:1.15.1
+| | +--- com.squareup.okio:okio:3.7.0 -> 3.9.0 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
+| +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3 -> 1.8.1 (*)
+| +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*)
++--- com.gravatar:gravatar:2.2.0 (*)
+\--- com.gravatar:gravatar-quickeditor:2.2.0
+ +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.25 -> 2.0.21 (*)
+ +--- com.gravatar:gravatar:2.2.0 (*)
+ +--- com.gravatar:gravatar-ui:2.2.0
+ | +--- androidx.core:core-ktx:1.13.1 (*)
+ | +--- androidx.appcompat:appcompat:1.7.0 (*)
+ | +--- com.google.android.material:material:1.12.0 (*)
+ | +--- io.coil-kt:coil-compose:2.7.0
+ | | +--- io.coil-kt:coil-compose-base:2.7.0
+ | | | +--- androidx.core:core-ktx:1.12.0 -> 1.13.1 (*)
+ | | | +--- com.google.accompanist:accompanist-drawablepainter:0.32.0 (*)
+ | | | +--- io.coil-kt:coil-base:2.7.0
+ | | | | +--- androidx.annotation:annotation:1.7.1 -> 1.9.1 (*)
+ | | | | +--- androidx.appcompat:appcompat-resources:1.6.1 -> 1.7.0 (*)
+ | | | | +--- androidx.collection:collection:1.4.0 -> 1.4.4 (*)
+ | | | | +--- androidx.core:core-ktx:1.12.0 -> 1.13.1 (*)
+ | | | | +--- androidx.exifinterface:exifinterface:1.3.7 (*)
+ | | | | +--- androidx.profileinstaller:profileinstaller:1.3.1 -> 1.4.0 (*)
+ | | | | +--- androidx.lifecycle:lifecycle-runtime:2.7.0 -> 2.8.7 (*)
+ | | | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
+ | | | | +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.0 -> 2.0.21 (*)
+ | | | | +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+ | | | | \--- com.squareup.okio:okio:3.9.0 (*)
+ | | | +--- androidx.compose.foundation:foundation:1.6.8 -> 1.7.6 (*)
+ | | | \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.0 -> 2.0.21 (*)
+ | | +--- io.coil-kt:coil:2.7.0
+ | | | +--- io.coil-kt:coil-base:2.7.0 (*)
+ | | | \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.0 -> 2.0.21 (*)
+ | | \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.0 -> 2.0.21 (*)
+ | +--- io.coil-kt:coil-svg:2.7.0
+ | | +--- androidx.core:core-ktx:1.12.0 -> 1.13.1 (*)
+ | | +--- com.caverock:androidsvg-aar:1.4
+ | | +--- io.coil-kt:coil-base:2.7.0 (*)
+ | | \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.0 -> 2.0.21 (*)
+ | +--- com.gravatar:gravatar:2.2.0 (*)
+ | +--- androidx.compose:compose-bom:2024.02.00 -> 2024.12.01
+ | | +--- androidx.compose.animation:animation:1.7.6 (c)
+ | | +--- androidx.compose.foundation:foundation:1.7.6 (c)
+ | | +--- androidx.compose.foundation:foundation-layout:1.7.6 (c)
+ | | +--- androidx.compose.material:material:1.7.6 (c)
+ | | +--- androidx.compose.material3:material3:1.3.1 (c)
+ | | +--- androidx.compose.material3.adaptive:adaptive:1.0.0 (c)
+ | | +--- androidx.compose.runtime:runtime:1.7.6 (c)
+ | | +--- androidx.compose.runtime:runtime-livedata:1.7.6 (c)
+ | | +--- androidx.compose.runtime:runtime-saveable:1.7.6 (c)
+ | | +--- androidx.compose.ui:ui:1.7.6 (c)
+ | | +--- androidx.compose.ui:ui-graphics:1.7.6 (c)
+ | | +--- androidx.compose.ui:ui-text:1.7.6 (c)
+ | | +--- androidx.compose.ui:ui-tooling:1.7.6 (c)
+ | | +--- androidx.compose.ui:ui-tooling-preview:1.7.6 (c)
+ | | +--- androidx.compose.ui:ui-unit:1.7.6 (c)
+ | | +--- androidx.compose.material3:material3-android:1.3.1 (c)
+ | | +--- androidx.compose.material3.adaptive:adaptive-android:1.0.0 (c)
+ | | +--- androidx.compose.animation:animation-android:1.7.6 (c)
+ | | +--- androidx.compose.foundation:foundation-android:1.7.6 (c)
+ | | +--- androidx.compose.foundation:foundation-layout-android:1.7.6 (c)
+ | | +--- androidx.compose.material:material-android:1.7.6 (c)
+ | | +--- androidx.compose.runtime:runtime-android:1.7.6 (c)
+ | | +--- androidx.compose.runtime:runtime-saveable-android:1.7.6 (c)
+ | | +--- androidx.compose.ui:ui-android:1.7.6 (c)
+ | | +--- androidx.compose.ui:ui-graphics-android:1.7.6 (c)
+ | | +--- androidx.compose.ui:ui-text-android:1.7.6 (c)
+ | | +--- androidx.compose.ui:ui-tooling-android:1.7.6 (c)
+ | | +--- androidx.compose.ui:ui-tooling-preview-android:1.7.6 (c)
+ | | +--- androidx.compose.ui:ui-unit-android:1.7.6 (c)
+ | | +--- androidx.compose.ui:ui-util:1.7.6 (c)
+ | | +--- androidx.compose.animation:animation-core:1.7.6 (c)
+ | | +--- androidx.compose.material:material-icons-core:1.7.6 (c)
+ | | +--- androidx.compose.material:material-ripple:1.7.6 (c)
+ | | +--- androidx.compose.ui:ui-geometry:1.7.6 (c)
+ | | +--- androidx.compose.ui:ui-tooling-data:1.7.6 (c)
+ | | +--- androidx.compose.ui:ui-util-android:1.7.6 (c)
+ | | +--- androidx.compose.animation:animation-core-android:1.7.6 (c)
+ | | +--- androidx.compose.material:material-icons-core-android:1.7.6 (c)
+ | | +--- androidx.compose.material:material-ripple-android:1.7.6 (c)
+ | | +--- androidx.compose.ui:ui-geometry-android:1.7.6 (c)
+ | | \--- androidx.compose.ui:ui-tooling-data-android:1.7.6 (c)
+ | +--- androidx.compose.ui:ui -> 1.7.6 (*)
+ | +--- androidx.compose.ui:ui-tooling-preview -> 1.7.6 (*)
+ | +--- androidx.compose.material3:material3 -> 1.3.1
+ | | \--- androidx.compose.material3:material3-android:1.3.1
+ | | +--- androidx.activity:activity-compose:1.8.2 -> 1.9.3 (*)
+ | | +--- androidx.annotation:annotation:1.1.0 -> 1.9.1 (*)
+ | | +--- androidx.annotation:annotation-experimental:1.4.0 -> 1.4.1 (*)
+ | | +--- androidx.collection:collection:1.4.0 -> 1.4.4 (*)
+ | | +--- androidx.compose.animation:animation-core:1.6.0 -> 1.7.6 (*)
+ | | +--- androidx.compose.foundation:foundation:1.7.0 -> 1.7.6 (*)
+ | | +--- androidx.compose.foundation:foundation-layout:1.7.0 -> 1.7.6 (*)
+ | | +--- androidx.compose.material:material-icons-core:1.6.0 -> 1.7.6
+ | | | \--- androidx.compose.material:material-icons-core-android:1.7.6
+ | | | +--- androidx.compose.ui:ui:1.6.0 -> 1.7.6 (*)
+ | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
+ | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.22 -> 2.0.21 (*)
+ | | +--- androidx.compose.material:material-ripple:1.7.0 -> 1.7.6 (*)
+ | | +--- androidx.compose.runtime:runtime:1.7.0 -> 1.7.6 (*)
+ | | +--- androidx.compose.ui:ui:1.6.0 -> 1.7.6 (*)
+ | | +--- androidx.compose.ui:ui-text:1.6.0 -> 1.7.6 (*)
+ | | +--- androidx.compose.ui:ui-util:1.6.0 -> 1.7.6 (*)
+ | | +--- androidx.lifecycle:lifecycle-common-java8:2.6.1 -> 2.8.7 (*)
+ | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.22 -> 2.0.21 (*)
+ | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*)
+ +--- androidx.browser:browser:1.8.0
+ | +--- androidx.annotation:annotation:1.2.0 -> 1.9.1 (*)
+ | +--- androidx.annotation:annotation-experimental:1.4.0 -> 1.4.1 (*)
+ | +--- androidx.collection:collection:1.1.0 -> 1.4.4 (*)
+ | +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
+ | +--- androidx.core:core:1.1.0 -> 1.13.1 (*)
+ | +--- androidx.interpolator:interpolator:1.0.0 (*)
+ | \--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
+ +--- androidx.appcompat:appcompat:1.7.0 (*)
+ +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.8.3 -> 2.8.7 (*)
+ +--- androidx.navigation:navigation-compose:2.8.3 -> 2.8.5 (*)
+ +--- io.github.osipxd:security-crypto-datastore-preferences:1.1.1-beta03
+ | +--- io.github.osipxd:encrypted-datastore-preferences:1.1.1-beta03
+ | | +--- io.github.osipxd:encrypted-datastore-bom:1.1.1-beta03
+ | | | +--- io.github.osipxd:encrypted-datastore-preferences:1.1.1-beta03 (c)
+ | | | +--- io.github.osipxd:security-crypto-datastore:1.1.1-beta03 (c)
+ | | | +--- io.github.osipxd:security-crypto-datastore-preferences:1.1.1-beta03 (c)
+ | | | +--- androidx.datastore:datastore-preferences:1.1.1 (c)
+ | | | +--- io.github.osipxd:encrypted-datastore:1.1.1-beta03 (c)
+ | | | +--- androidx.datastore:datastore-preferences-core:1.1.1 (c)
+ | | | +--- androidx.datastore:datastore:1.1.1 (c)
+ | | | \--- androidx.datastore:datastore-core:1.1.1 (c)
+ | | +--- io.github.osipxd:encrypted-datastore:1.1.1-beta03
+ | | | +--- io.github.osipxd:encrypted-datastore-bom:1.1.1-beta03 (*)
+ | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.23 -> 2.0.21 (*)
+ | | | +--- androidx.datastore:datastore-core:1.1.1
+ | | | | \--- androidx.datastore:datastore-core-android:1.1.1
+ | | | | +--- androidx.annotation:annotation:1.7.0 -> 1.9.1 (*)
+ | | | | +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.22 -> 2.0.21 (*)
+ | | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
+ | | | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.8.1 (*)
+ | | | | +--- androidx.datastore:datastore:1.1.1 (c)
+ | | | | +--- androidx.datastore:datastore-core-okio:1.1.1 (c)
+ | | | | +--- androidx.datastore:datastore-preferences:1.1.1 (c)
+ | | | | \--- androidx.datastore:datastore-preferences-core:1.1.1 (c)
+ | | | \--- com.google.crypto.tink:tink-android:1.13.0 (*)
+ | | +--- androidx.datastore:datastore-preferences-core:1.1.1
+ | | | \--- androidx.datastore:datastore-preferences-core-jvm:1.1.1
+ | | | +--- androidx.datastore:datastore-core:1.1.1 (*)
+ | | | +--- androidx.datastore:datastore-core-okio:1.1.1
+ | | | | \--- androidx.datastore:datastore-core-okio-jvm:1.1.1
+ | | | | +--- androidx.datastore:datastore-core:1.1.1 (*)
+ | | | | +--- com.squareup.okio:okio:3.4.0 -> 3.9.0 (*)
+ | | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
+ | | | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.8.1 (*)
+ | | | | +--- androidx.datastore:datastore:1.1.1 (c)
+ | | | | +--- androidx.datastore:datastore-core:1.1.1 (c)
+ | | | | +--- androidx.datastore:datastore-preferences:1.1.1 (c)
+ | | | | \--- androidx.datastore:datastore-preferences-core:1.1.1 (c)
+ | | | +--- com.squareup.okio:okio:3.4.0 -> 3.9.0 (*)
+ | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
+ | | | +--- androidx.datastore:datastore:1.1.1 (c)
+ | | | +--- androidx.datastore:datastore-core:1.1.1 (c)
+ | | | +--- androidx.datastore:datastore-core-okio:1.1.1 (c)
+ | | | \--- androidx.datastore:datastore-preferences:1.1.1 (c)
+ | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.23 -> 2.0.21 (*)
+ | +--- io.github.osipxd:encrypted-datastore-bom:1.1.1-beta03 (*)
+ | +--- io.github.osipxd:security-crypto-datastore:1.1.1-beta03
+ | | +--- io.github.osipxd:encrypted-datastore:1.1.1-beta03 (*)
+ | | +--- io.github.osipxd:encrypted-datastore-bom:1.1.1-beta03 (*)
+ | | +--- androidx.datastore:datastore:1.1.1
+ | | | \--- androidx.datastore:datastore-android:1.1.1
+ | | | +--- androidx.annotation:annotation:1.2.0 -> 1.9.1 (*)
+ | | | +--- androidx.datastore:datastore-core:1.1.1 (*)
+ | | | +--- androidx.datastore:datastore-core-okio:1.1.1 (*)
+ | | | +--- com.squareup.okio:okio:3.4.0 -> 3.9.0 (*)
+ | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
+ | | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.8.1 (*)
+ | | | +--- androidx.datastore:datastore-core:1.1.1 (c)
+ | | | +--- androidx.datastore:datastore-core-okio:1.1.1 (c)
+ | | | +--- androidx.datastore:datastore-preferences:1.1.1 (c)
+ | | | \--- androidx.datastore:datastore-preferences-core:1.1.1 (c)
+ | | +--- androidx.security:security-crypto:1.0.0 (*)
+ | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.23 -> 2.0.21 (*)
+ | +--- androidx.datastore:datastore-preferences:1.1.1
+ | | \--- androidx.datastore:datastore-preferences-android:1.1.1
+ | | +--- androidx.datastore:datastore:1.1.1 (*)
+ | | +--- androidx.datastore:datastore-preferences-core:1.1.1 (*)
+ | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
+ | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.8.1 (*)
+ | | +--- androidx.datastore:datastore:1.1.1 (c)
+ | | +--- androidx.datastore:datastore-core:1.1.1 (c)
+ | | +--- androidx.datastore:datastore-preferences-core:1.1.1 (c)
+ | | \--- androidx.datastore:datastore-core-okio:1.1.1 (c)
+ | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.23 -> 2.0.21 (*)
+ +--- androidx.startup:startup-runtime:1.1.1 (*)
+ +--- io.coil-kt:coil-compose:2.7.0 (*)
+ +--- com.squareup.retrofit2:retrofit:2.11.0 (*)
+ +--- com.squareup.retrofit2:converter-moshi:2.11.0 (*)
+ +--- com.automattic:ucrop:2.2.10 (*)
+ +--- androidx.compose:compose-bom:2024.02.00 -> 2024.12.01 (*)
+ +--- androidx.compose.ui:ui -> 1.7.6 (*)
+ +--- androidx.compose.ui:ui-tooling-preview -> 1.7.6 (*)
+ +--- androidx.compose.material3:material3 -> 1.3.1 (*)
+ +--- androidx.activity:activity-compose:1.9.2 -> 1.9.3 (*)
+ +--- androidx.compose.material3.adaptive:adaptive:1.0.0
+ | \--- androidx.compose.material3.adaptive:adaptive-android:1.0.0
+ | +--- androidx.annotation:annotation:1.1.0 -> 1.9.1 (*)
+ | +--- androidx.annotation:annotation-experimental:1.4.0 -> 1.4.1 (*)
+ | +--- androidx.compose.foundation:foundation:1.6.5 -> 1.7.6 (*)
+ | +--- androidx.compose.ui:ui-geometry:1.6.5 -> 1.7.6 (*)
+ | +--- androidx.window:window:1.3.0 (*)
+ | +--- androidx.window:window-core:1.3.0
+ | | \--- androidx.window:window-core-android:1.3.0
+ | | +--- androidx.annotation:annotation:1.7.0 -> 1.9.1 (*)
+ | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
+ | | \--- androidx.window:window:1.3.0 (c)
+ | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
+ | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.22 -> 2.0.21 (*)
+ +--- com.composables:core:1.15.0
+ | \--- com.composables:core-android:1.15.0
+ | +--- androidx.activity:activity:1.9.0 -> 1.9.3 (*)
+ | +--- androidx.activity:activity-compose:1.9.0 -> 1.9.3 (*)
+ | +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.10 -> 2.0.21 (*)
+ | \--- org.jetbrains.compose.foundation:foundation:1.6.11
+ | \--- androidx.compose.foundation:foundation:1.6.7 -> 1.7.6 (*)
+ \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*)
-+--- project :libs:login
-| \--- com.gravatar:gravatar:2.0.1
-| +--- com.squareup.moshi:moshi-kotlin:1.15.1
-| | +--- com.squareup.moshi:moshi:1.15.1
-| | | +--- com.squareup.okio:okio:3.7.0 -> 3.9.0 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
-| | +--- org.jetbrains.kotlin:kotlin-reflect:1.8.21 -> 1.8.22
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
-| +--- com.squareup.retrofit2:retrofit:2.11.0
-| | \--- com.squareup.okhttp3:okhttp:3.14.9 -> 4.12.0 (*)
-| +--- com.squareup.retrofit2:converter-moshi:2.11.0
-| | +--- com.squareup.retrofit2:retrofit:2.11.0 (*)
-| | \--- com.squareup.moshi:moshi:1.15.1 (*)
-| +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3 -> 1.8.1 (*)
-| +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*)
-+--- com.gravatar:gravatar:2.0.1 (*)
-\--- com.gravatar:gravatar-quickeditor:2.0.1
- +--- com.gravatar:gravatar:2.0.1 (*)
- +--- com.gravatar:gravatar-ui:2.0.1
- | +--- androidx.core:core-ktx:1.13.1 (*)
- | +--- androidx.appcompat:appcompat:1.7.0 (*)
- | +--- com.google.android.material:material:1.12.0 (*)
- | +--- io.coil-kt:coil-compose:2.7.0
- | | +--- io.coil-kt:coil-compose-base:2.7.0
- | | | +--- androidx.core:core-ktx:1.12.0 -> 1.13.1 (*)
- | | | +--- com.google.accompanist:accompanist-drawablepainter:0.32.0 (*)
- | | | +--- io.coil-kt:coil-base:2.7.0
- | | | | +--- androidx.annotation:annotation:1.7.1 -> 1.9.1 (*)
- | | | | +--- androidx.appcompat:appcompat-resources:1.6.1 -> 1.7.0 (*)
- | | | | +--- androidx.collection:collection:1.4.0 -> 1.4.4 (*)
- | | | | +--- androidx.core:core-ktx:1.12.0 -> 1.13.1 (*)
- | | | | +--- androidx.exifinterface:exifinterface:1.3.7 (*)
- | | | | +--- androidx.profileinstaller:profileinstaller:1.3.1 -> 1.4.0 (*)
- | | | | +--- androidx.lifecycle:lifecycle-runtime:2.7.0 -> 2.8.7 (*)
- | | | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
- | | | | +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.0 -> 2.0.21 (*)
- | | | | +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
- | | | | \--- com.squareup.okio:okio:3.9.0 (*)
- | | | +--- androidx.compose.foundation:foundation:1.6.8 -> 1.7.6 (*)
- | | | \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.0 -> 2.0.21 (*)
- | | +--- io.coil-kt:coil:2.7.0
- | | | +--- io.coil-kt:coil-base:2.7.0 (*)
- | | | \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.0 -> 2.0.21 (*)
- | | \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.0 -> 2.0.21 (*)
- | +--- io.coil-kt:coil-svg:2.7.0
- | | +--- androidx.core:core-ktx:1.12.0 -> 1.13.1 (*)
- | | +--- com.caverock:androidsvg-aar:1.4
- | | +--- io.coil-kt:coil-base:2.7.0 (*)
- | | \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.0 -> 2.0.21 (*)
- | +--- com.gravatar:gravatar:2.0.1 (*)
- | +--- androidx.compose:compose-bom:2024.02.00 -> 2024.12.01
- | | +--- androidx.compose.animation:animation:1.7.6 (c)
- | | +--- androidx.compose.foundation:foundation:1.7.6 (c)
- | | +--- androidx.compose.foundation:foundation-layout:1.7.6 (c)
- | | +--- androidx.compose.material:material:1.7.6 (c)
- | | +--- androidx.compose.material3:material3:1.3.1 (c)
- | | +--- androidx.compose.material3.adaptive:adaptive:1.0.0 (c)
- | | +--- androidx.compose.runtime:runtime:1.7.6 (c)
- | | +--- androidx.compose.runtime:runtime-livedata:1.7.6 (c)
- | | +--- androidx.compose.runtime:runtime-saveable:1.7.6 (c)
- | | +--- androidx.compose.ui:ui:1.7.6 (c)
- | | +--- androidx.compose.ui:ui-graphics:1.7.6 (c)
- | | +--- androidx.compose.ui:ui-text:1.7.6 (c)
- | | +--- androidx.compose.ui:ui-tooling:1.7.6 (c)
- | | +--- androidx.compose.ui:ui-tooling-preview:1.7.6 (c)
- | | +--- androidx.compose.ui:ui-unit:1.7.6 (c)
- | | +--- androidx.compose.material3:material3-android:1.3.1 (c)
- | | +--- androidx.compose.material3.adaptive:adaptive-android:1.0.0 (c)
- | | +--- androidx.compose.animation:animation-android:1.7.6 (c)
- | | +--- androidx.compose.foundation:foundation-android:1.7.6 (c)
- | | +--- androidx.compose.foundation:foundation-layout-android:1.7.6 (c)
- | | +--- androidx.compose.material:material-android:1.7.6 (c)
- | | +--- androidx.compose.runtime:runtime-android:1.7.6 (c)
- | | +--- androidx.compose.runtime:runtime-saveable-android:1.7.6 (c)
- | | +--- androidx.compose.ui:ui-android:1.7.6 (c)
- | | +--- androidx.compose.ui:ui-graphics-android:1.7.6 (c)
- | | +--- androidx.compose.ui:ui-text-android:1.7.6 (c)
- | | +--- androidx.compose.ui:ui-tooling-android:1.7.6 (c)
- | | +--- androidx.compose.ui:ui-tooling-preview-android:1.7.6 (c)
- | | +--- androidx.compose.ui:ui-unit-android:1.7.6 (c)
- | | +--- androidx.compose.ui:ui-util:1.7.6 (c)
- | | +--- androidx.compose.animation:animation-core:1.7.6 (c)
- | | +--- androidx.compose.material:material-icons-core:1.7.6 (c)
- | | +--- androidx.compose.material:material-ripple:1.7.6 (c)
- | | +--- androidx.compose.ui:ui-geometry:1.7.6 (c)
- | | +--- androidx.compose.ui:ui-tooling-data:1.7.6 (c)
- | | +--- androidx.compose.ui:ui-util-android:1.7.6 (c)
- | | +--- androidx.compose.animation:animation-core-android:1.7.6 (c)
- | | +--- androidx.compose.material:material-icons-core-android:1.7.6 (c)
- | | +--- androidx.compose.material:material-ripple-android:1.7.6 (c)
- | | +--- androidx.compose.ui:ui-geometry-android:1.7.6 (c)
- | | \--- androidx.compose.ui:ui-tooling-data-android:1.7.6 (c)
- | +--- androidx.compose.ui:ui -> 1.7.6 (*)
- | +--- androidx.compose.ui:ui-tooling-preview -> 1.7.6 (*)
- | +--- androidx.compose.material3:material3 -> 1.3.1
- | | \--- androidx.compose.material3:material3-android:1.3.1
- | | +--- androidx.activity:activity-compose:1.8.2 -> 1.9.3 (*)
- | | +--- androidx.annotation:annotation:1.1.0 -> 1.9.1 (*)
- | | +--- androidx.annotation:annotation-experimental:1.4.0 -> 1.4.1 (*)
- | | +--- androidx.collection:collection:1.4.0 -> 1.4.4 (*)
- | | +--- androidx.compose.animation:animation-core:1.6.0 -> 1.7.6 (*)
- | | +--- androidx.compose.foundation:foundation:1.7.0 -> 1.7.6 (*)
- | | +--- androidx.compose.foundation:foundation-layout:1.7.0 -> 1.7.6 (*)
- | | +--- androidx.compose.material:material-icons-core:1.6.0 -> 1.7.6
- | | | \--- androidx.compose.material:material-icons-core-android:1.7.6
- | | | +--- androidx.compose.ui:ui:1.6.0 -> 1.7.6 (*)
- | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
- | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.22 -> 2.0.21 (*)
- | | +--- androidx.compose.material:material-ripple:1.7.0 -> 1.7.6 (*)
- | | +--- androidx.compose.runtime:runtime:1.7.0 -> 1.7.6 (*)
- | | +--- androidx.compose.ui:ui:1.6.0 -> 1.7.6 (*)
- | | +--- androidx.compose.ui:ui-text:1.6.0 -> 1.7.6 (*)
- | | +--- androidx.compose.ui:ui-util:1.6.0 -> 1.7.6 (*)
- | | +--- androidx.lifecycle:lifecycle-common-java8:2.6.1 -> 2.8.7 (*)
- | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.22 -> 2.0.21 (*)
- | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*)
- +--- androidx.browser:browser:1.8.0
- | +--- androidx.annotation:annotation:1.2.0 -> 1.9.1 (*)
- | +--- androidx.annotation:annotation-experimental:1.4.0 -> 1.4.1 (*)
- | +--- androidx.collection:collection:1.1.0 -> 1.4.4 (*)
- | +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
- | +--- androidx.core:core:1.1.0 -> 1.13.1 (*)
- | +--- androidx.interpolator:interpolator:1.0.0 (*)
- | \--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
- +--- androidx.appcompat:appcompat:1.7.0 (*)
- +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.8.3 -> 2.8.7 (*)
- +--- androidx.navigation:navigation-compose:2.8.1 -> 2.8.5 (*)
- +--- io.github.osipxd:security-crypto-datastore-preferences:1.1.1-beta03
- | +--- io.github.osipxd:encrypted-datastore-preferences:1.1.1-beta03
- | | +--- io.github.osipxd:encrypted-datastore-bom:1.1.1-beta03
- | | | +--- io.github.osipxd:encrypted-datastore-preferences:1.1.1-beta03 (c)
- | | | +--- io.github.osipxd:security-crypto-datastore:1.1.1-beta03 (c)
- | | | +--- io.github.osipxd:security-crypto-datastore-preferences:1.1.1-beta03 (c)
- | | | +--- androidx.datastore:datastore-preferences:1.1.1 (c)
- | | | +--- io.github.osipxd:encrypted-datastore:1.1.1-beta03 (c)
- | | | +--- androidx.datastore:datastore-preferences-core:1.1.1 (c)
- | | | +--- androidx.datastore:datastore:1.1.1 (c)
- | | | \--- androidx.datastore:datastore-core:1.1.1 (c)
- | | +--- io.github.osipxd:encrypted-datastore:1.1.1-beta03
- | | | +--- io.github.osipxd:encrypted-datastore-bom:1.1.1-beta03 (*)
- | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.23 -> 2.0.21 (*)
- | | | +--- androidx.datastore:datastore-core:1.1.1
- | | | | \--- androidx.datastore:datastore-core-android:1.1.1
- | | | | +--- androidx.annotation:annotation:1.7.0 -> 1.9.1 (*)
- | | | | +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.22 -> 2.0.21 (*)
- | | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
- | | | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.8.1 (*)
- | | | | +--- androidx.datastore:datastore:1.1.1 (c)
- | | | | +--- androidx.datastore:datastore-core-okio:1.1.1 (c)
- | | | | +--- androidx.datastore:datastore-preferences:1.1.1 (c)
- | | | | \--- androidx.datastore:datastore-preferences-core:1.1.1 (c)
- | | | \--- com.google.crypto.tink:tink-android:1.13.0 (*)
- | | +--- androidx.datastore:datastore-preferences-core:1.1.1
- | | | \--- androidx.datastore:datastore-preferences-core-jvm:1.1.1
- | | | +--- androidx.datastore:datastore-core:1.1.1 (*)
- | | | +--- androidx.datastore:datastore-core-okio:1.1.1
- | | | | \--- androidx.datastore:datastore-core-okio-jvm:1.1.1
- | | | | +--- androidx.datastore:datastore-core:1.1.1 (*)
- | | | | +--- com.squareup.okio:okio:3.4.0 -> 3.9.0 (*)
- | | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
- | | | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.8.1 (*)
- | | | | +--- androidx.datastore:datastore:1.1.1 (c)
- | | | | +--- androidx.datastore:datastore-core:1.1.1 (c)
- | | | | +--- androidx.datastore:datastore-preferences:1.1.1 (c)
- | | | | \--- androidx.datastore:datastore-preferences-core:1.1.1 (c)
- | | | +--- com.squareup.okio:okio:3.4.0 -> 3.9.0 (*)
- | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
- | | | +--- androidx.datastore:datastore:1.1.1 (c)
- | | | +--- androidx.datastore:datastore-core:1.1.1 (c)
- | | | +--- androidx.datastore:datastore-core-okio:1.1.1 (c)
- | | | \--- androidx.datastore:datastore-preferences:1.1.1 (c)
- | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.23 -> 2.0.21 (*)
- | +--- io.github.osipxd:encrypted-datastore-bom:1.1.1-beta03 (*)
- | +--- io.github.osipxd:security-crypto-datastore:1.1.1-beta03
- | | +--- io.github.osipxd:encrypted-datastore:1.1.1-beta03 (*)
- | | +--- io.github.osipxd:encrypted-datastore-bom:1.1.1-beta03 (*)
- | | +--- androidx.datastore:datastore:1.1.1
- | | | \--- androidx.datastore:datastore-android:1.1.1
- | | | +--- androidx.annotation:annotation:1.2.0 -> 1.9.1 (*)
- | | | +--- androidx.datastore:datastore-core:1.1.1 (*)
- | | | +--- androidx.datastore:datastore-core-okio:1.1.1 (*)
- | | | +--- com.squareup.okio:okio:3.4.0 -> 3.9.0 (*)
- | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
- | | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.8.1 (*)
- | | | +--- androidx.datastore:datastore-core:1.1.1 (c)
- | | | +--- androidx.datastore:datastore-core-okio:1.1.1 (c)
- | | | +--- androidx.datastore:datastore-preferences:1.1.1 (c)
- | | | \--- androidx.datastore:datastore-preferences-core:1.1.1 (c)
- | | +--- androidx.security:security-crypto:1.0.0 (*)
- | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.23 -> 2.0.21 (*)
- | +--- androidx.datastore:datastore-preferences:1.1.1
- | | \--- androidx.datastore:datastore-preferences-android:1.1.1
- | | +--- androidx.datastore:datastore:1.1.1 (*)
- | | +--- androidx.datastore:datastore-preferences-core:1.1.1 (*)
- | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
- | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.8.1 (*)
- | | +--- androidx.datastore:datastore:1.1.1 (c)
- | | +--- androidx.datastore:datastore-core:1.1.1 (c)
- | | +--- androidx.datastore:datastore-preferences-core:1.1.1 (c)
- | | \--- androidx.datastore:datastore-core-okio:1.1.1 (c)
- | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.23 -> 2.0.21 (*)
- +--- androidx.startup:startup-runtime:1.1.1 (*)
- +--- io.coil-kt:coil-compose:2.7.0 (*)
- +--- com.squareup.retrofit2:retrofit:2.11.0 (*)
- +--- com.squareup.retrofit2:converter-moshi:2.11.0 (*)
- +--- com.automattic:ucrop:2.2.10 (*)
- +--- androidx.compose:compose-bom:2024.02.00 -> 2024.12.01 (*)
- +--- androidx.compose.ui:ui -> 1.7.6 (*)
- +--- androidx.compose.ui:ui-tooling-preview -> 1.7.6 (*)
- +--- androidx.compose.material3:material3 -> 1.3.1 (*)
- +--- androidx.activity:activity-compose:1.9.2 -> 1.9.3 (*)
- +--- androidx.compose.material3.adaptive:adaptive:1.0.0
- | \--- androidx.compose.material3.adaptive:adaptive-android:1.0.0
- | +--- androidx.annotation:annotation:1.1.0 -> 1.9.1 (*)
- | +--- androidx.annotation:annotation-experimental:1.4.0 -> 1.4.1 (*)
- | +--- androidx.compose.foundation:foundation:1.6.5 -> 1.7.6 (*)
- | +--- androidx.compose.ui:ui-geometry:1.6.5 -> 1.7.6 (*)
- | +--- androidx.window:window:1.3.0 (*)
- | +--- androidx.window:window-core:1.3.0
- | | \--- androidx.window:window-core-android:1.3.0
- | | +--- androidx.annotation:annotation:1.7.0 -> 1.9.1 (*)
- | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
- | | \--- androidx.window:window:1.3.0 (c)
- | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
- | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.22 -> 2.0.21 (*)
- +--- com.composables:core:1.15.0
- | \--- com.composables:core-android:1.15.0
- | +--- androidx.activity:activity:1.9.0 -> 1.9.3 (*)
- | +--- androidx.activity:activity-compose:1.9.0 -> 1.9.3 (*)
- | +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.10 -> 2.0.21 (*)
- | \--- org.jetbrains.compose.foundation:foundation:1.6.11
- | \--- androidx.compose.foundation:foundation:1.6.7 -> 1.7.6 (*)
- \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*) |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AdamGrzybkowski I'll approve this but wanted to point out some unexpected behavior that's unrelated to this PR. When I tapped my profile pic on the Me tab, it correctly showed two profile photos I previously added. But when I tapped a photo, instead of updating my profile pic it gave me the option to either delete or download the photo. I chose to download and was told I would get a notification when the download completed, but I never received one. I waited a minute, tapped the photo again, and then it changed my profile pic.
Update: Just to clarify, my expectation was that tapping a photo would change my profile pic. I didn't understand why I needed to download it first.
Thanks for the feedback @nbradbury You don't need to download the Image to select it. There's a button on the Avatar in the bottom right corner that when tapped would display the Popup with the options you mentioned. I guess you might have missed it.
We don't control the notifications here, DownloadManager does. It's a system app. One reason could be that the notifications are disabled. If you don't mind checking you can do it in: System settings -> Apps -> Show system apps -> Download Manager. |
Once again my eyesight has failed me! Sorry for the false alarm. Feel free to merge when ready. |
This PR bumps the Gravatar SDK to 2.2.0. You can see the release notes here.
In short, this updates brings two new options to manage your existing Avatars:
There were other fixes and updates, but these two are the most noticeable ones for the WP app.
On the Dependency side of things. We no longer use
moshi-kotlin
which meanskotlin-reflect
is not longer added. That will mean a smaller app size.To Test:
Technically speaking, there's not much to test on the WP side since the features provided in the SDK have already been tested. Feel free to test this yourself.
...
button on an Avatar and pick one of the optionsYou can
Regression Notes
You can see that I had to add
tools:replace="android:maxSdkVersion"
to theAndroidManifest.xml
. This ensures that no changes to the WP manifest are done and themaxSdkVersion=29
is kept. Quick Editor needs theandroid.permission.WRITE_EXTERNAL_STORAGE
permission but only up to API 28, so that's where the conflict is. This permission is needed for the DownloadManager (see docs) to download Avatars.Here's a screenshot of the merge AndroidManifest from the .apk confirming no changes are made.
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):