-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature branch: per-app language preferences #21538
Conversation
…age-from-jp-migration
Generated by 🚫 Danger |
Quality Gate passedIssues Measures |
👋 @nbradbury ! Quick question, because I'll be off on AFK from Monday, actually approaching EOD atm, do you need that merged today? 🤔 FYI: I am asking that because it would be valuable for someone other than me to review this final merge to |
Noted @nbradbury , I'll then test this once more in about an hour (or so) and then (most probably) approve it too (✅), I am sure there are no changes between this and the previous PR we were working on just few minutes ago. 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @nbradbury !
I have reviewed (quickly again) and tested this (once more), everything works as expected, a great great job well done, kudos! 🚀 x 🚀 ^ 🚀
So much code removed, love it! ❤️
This is the feature branch for per-app language preferences. All code has been reviewed in previous PRs, but a quick test is still recommended: