Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dark mode in Blaze WebViews #21488

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

nbradbury
Copy link
Contributor

Fixes #21487

Previously Blaze web views would show with light mode colors even in dark mode. This PR addresses this.

To test:

  • Enable dark mode either in the app or the device
  • Tap the ☰ menu on the Blaze card
  • Tap "Learn more"
  • Tap "Blaze a post right now"
  • Verify the WebView screen uses dark colors
  • Disable dark mode and verify Blaze uses light colors

Note: Dark mode support is only available in Android 33 (Tiramisu) and above.

dark.mp4

@nbradbury nbradbury added the UI label Nov 22, 2024
@nbradbury nbradbury changed the title Use setAlgorithmicDarkeningAllowed Support dark mode in Blaze WebViews Nov 22, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 22, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21488-06aad70
Commit06aad70
Direct Downloadjetpack-prototype-build-pr21488-06aad70.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21488-06aad70
Commit06aad70
Direct Downloadwordpress-prototype-build-pr21488-06aad70.apk
Note: Google Login is not supported on these builds.

@nbradbury nbradbury marked this pull request as ready for review November 22, 2024 21:14
@nbradbury nbradbury requested a review from dcalhoun November 22, 2024 21:15
@nbradbury nbradbury merged commit a8ce4ba into trunk Nov 25, 2024
26 checks passed
@nbradbury nbradbury deleted the issue/21487-blaze-dark-mode branch November 25, 2024 15:04
Copy link

sentry-io bot commented Nov 30, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ApplicationNotResponding: ANR org.wordpress.android.ui.blaze.blazepromote.Bla... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support dark mode in Blaze
4 participants